Contrib.social

Fix PHPStan L1 errors "You should use assertFoo() instead of assertSame(foo, $actual)."

Open on Drupal.org →
Created on 29 March 2023, over 1 year ago

Problem/Motivation

Amongst the current suppressions found in the PHPStan level 1 baseline, introduce by the adding of phpstan/phpstan-phpunit, is: You should use assertFoo() instead of assertSame(Foo, $actual)..

This issue exists to fix all of those.

NOTE: There's a separate issue for You should use assertNull() instead of assertSame(null, $actual). 📌 Fix PHPStan L1 errors "You should use assertNull() instead of assertSame(null, $actual)." Fixed , so these won't be fixed in here.

Steps to reproduce

- Run PHPStan on level 1 and see the above issue amongst all others.

Proposed resolution

- Solve all of the reported issues for the above mentioned.
- Run PHPStan on level 1 and don't see the above issue any more.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task
Status

Fixed

Version

10.1 ✨

Component
Base  →

Last updated about 2 hours ago

Created by

🇳🇱Netherlands spokje

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024