- Issue created by @spokje
- @spokje opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 12:46pm 29 March 2023 - Status changed to RTBC
over 1 year ago 1:58pm 29 March 2023 - πΊπΈUnited States smustgrave
From what I can tell this is a valid cleanup.
The MR passing shows it applies cleanly and doesn't generate errors.
- Status changed to Needs work
over 1 year ago 3:42pm 29 March 2023 - π¬π§United Kingdom catch
I'm seeing errors like
Ignored error pattern #^Annotation "@covers\:\:buildLocalUrl" is invalid, "@covers" should be followed by a space and a value\.$# in path /home/catch/www/drupal/core/tests/Drupal/Tests/Core/Utility/UnroutedUrlAssemblerTest.php was not matched in reported errors.
in core commit checks.
- π³π±Netherlands spokje
Hmmm, that specific one is handled in π Fix PHPStan L1 errors "Annotation "@covers::foo" is invalid, "@covers" should be followed by a space and a value." Fixed , unsure why that shows up in commit checks for this one.
Also: What are these commit checks and can mere mortal people trigger those?
- Status changed to RTBC
over 1 year ago 3:55pm 29 March 2023 - π¬π§United Kingdom catch
You can run ./core/scripts/dev/commit-code-check.sh
Also I think I was missing a composer update
- π³π±Netherlands spokje
You can run ./core/scripts/dev/commit-code-check.sh
Ah, i actually (almost) use that on any issue.
Thought there might be some "special sauce" somewhere.Also I think I was missing a composer update
Root cause found, normality restored.
- π¬π§United Kingdom catch
Yep, that was the problem.
Committed/pushed to 10.1.x, thanks!
- Status changed to Fixed
over 1 year ago 8:18pm 29 March 2023 Automatically closed - issue fixed for 2 weeks with no activity.