Improve re-use an existing field user experience

tim.plunkett → made their first commit to this issue’s fork.

One recommendation I have at this point is that after re-using a field, we redirect the user to the field config form instead of opening it in a modal dialog. We want to move the field config form into a modal dialog but we should do that consistently for all instances where that form is being accessed as part of ✨ Use modals on the Manage Fields page Needs work .

Few comments:

1. I think we should remove the options to re-use field from /admin/structure/types/manage/page/fields/add-field. This probably requires refactoring some tests but will also make sure that we have sufficient test coverage for the new UI.
2. The "Add field" local action may lead into some confusion since we now have another local action for re-using an existing field. I think we should make the pre-existing local action more explicit about what it's supposed to be used for, for example "Create a new field".
3. The search is really nice 👍 Can we improve the search slightly to do a contains search instead of starts with? Not a strict requirement for this issue but I think it would be nice to be also able to search based on field type.

Tested on a standard install of 10.1.x
Went into the manage field for the Basic page content type
Verified button Re-use an existing field
Clicking it showed the fields from the Article content type which the basic page doesn't have
Selected a field and it was added just fine.
Clicked button again and list updated as expected.

Accessibility tested
When modal opens focus goes to search box
Tabbing stays within the modal and follows logic path.

Posted feedback on the MR. 😇

I was testing this and I have 2 concerns:

1. What should be the label or description ("Filter by field or field type") is used as a placeholder. I understand this is trying to save space, but it is usually discouraged to use a placeholder like this because you loose that meaningful information once you start entering info. I'd suggest moving it into a label.

2. The search box doesn't work, it's not filtering.

#16.1 This is implementing a pre-existing pattern from /admin/modules. Do you think it would be acceptable to open a follow-up issue to revisit this pattern and fix it for all instances of this?

Few more comments on the MR

I hope the CI will be 🟢 now 😅

Seems to have a test failure.

This commit broke \Drupal\Tests\field_ui\FunctionalJavascript\ManageFieldsTest::testFilterInReuseForm because it is still trying to use the HTML IDs that were removed

Fixed tests and added some minor fixes. Hoping that CI remains 🟢 🤣

Everything works as expected, and this has pretty good code coverage.

@lauriii, @bnjmnm, and I had a quick discussion on "Re-use" vs "Reuse", and this MR matches what other UI strings do (with the hyphen), so if there's a desire to standardize on "Reuse" that should be opened as a follow-up.

After many rounds of feedback, this change looks like it's ready to go into core. This is a UX improvement I've been hoping to see for many years and happy to be the one committing it to 10.1.x.

Tagging as a possible highlight for the release, UX improvements are always welcome.

Automatically closed - issue fixed for 2 weeks with no activity.

The new design is great, thanks! I wanted to try it, and thought something was wrong: I opened the Article "Manage fields" and there was no "Re-use an existing field" button ... for logical reasons. So I created ✨ Alert that no fields can be re-used? Active .