- Issue created by @samit.310@gmail.com
- Issue was unassigned.
- Status changed to Needs review
about 2 years ago 3:30am 2 March 2023 - Assigned to omkar_yewale
- Issue was unassigned.
- Status changed to RTBC
about 2 years ago 4:05am 2 March 2023 - ๐ฎ๐ณIndia omkar_yewale Mumbai
Thanks for the patch, All phpcs issues are fixed. Marking as RTBC.
- ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
The tag for coding standards issues is Coding standards.
- Status changed to Needs work
about 2 years ago 5:00am 2 March 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
/** * @file + * Primary module hooks for Views Attachments as Tabs module. */
Whenever that is the primary module or not, the file contains its hook implementations. There is no need to say primary module. There must be an extra space too.
- ๐ฎ๐ณIndia pray_12
Preethy_ray โ made their first commit to this issueโs fork.
- ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
/** * @file + * Contains hooks and functions related to Views Attachment Tabs. */
See my previous comment ๐ Fix the issues reported by phpcs Needs work .
- $attachment_after[$attachment['#display_id']]['#attachment_index'] = $index;; + $attachment_after[$attachment['#display_id']]['#attachment_index'] = $index; + ;
There is no need to have two semicolons. Putting the second one on a new line does not correct the code.
- Assigned to nitin_lama
- Status changed to Needs review
over 1 year ago 11:15am 1 December 2023 - Issue was unassigned.
- First commit to issue fork.
-
andileco โ
committed 64724db3 on 1.1.x authored by
nitin_lama โ
Issue #3345382: Fix the issues reported by phpcs
-
andileco โ
committed 64724db3 on 1.1.x authored by
nitin_lama โ
- Status changed to Fixed
12 months ago 3:57pm 18 March 2024 Automatically closed - issue fixed for 2 weeks with no activity.