- Issue created by @Jay Jangid
- Merge request !4Issue #3339820: Drupal Coding Standards Issues | phpcs → (Open) created by Jay Jangid
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 7:01am 7 February 2023 - Assigned to Indra patil
- Status changed to Needs work
over 1 year ago 9:20am 7 February 2023 - 🇦🇺Australia darvanen Sydney, Australia
Thanks for this contribution Jay, the purpose of the phpcs rules is to prompt us to write good documentation. What exists here at the moment is filler.
If you can properly document the code, perhaps in collaboration with Indra, then it will be something worth adding to the codebase.
Take your time, use the module and follow it with a step-debugger, look at what the variables, methods and classes do and represent then put that in the documentation.
- Issue was unassigned.
- 🇦🇺Australia darvanen Sydney, Australia
In line with my new policy to only provide credit for code standards updates where the user has not already been provided with a credit for such changes, I am removing credit from this issue.
- 🇦🇺Australia darvanen Sydney, Australia
Now that GitLab is being implemented I'm going to retract #8. Credit will be supplied for contributing to successfully getting the phpcs job to run and pass with *relevant* changes in line with #6. The pipeline will be available once 📌 Gitlab integration Needs review is committed.
I've updated the issue summary.
- 🇦🇺Australia sime Canberra
Once gitlab CI yaml 📌 Gitlab integration Needs review is in you'll need to rebase and remove the " SKIP_PHPCS: '1'" line.
- First commit to issue fork.
- Status changed to Needs review
2 months ago 2:49pm 22 April 2024 - Assigned to amanmansuri72
- Status changed to RTBC
2 months ago 7:45am 23 April 2024 - 🇮🇳India Chandansha
I have tested MR 14 and cannot find any phpcs issue so I move forward to RTBC.
- Status changed to Needs work
2 months ago 10:33pm 23 April 2024 - 🇦🇺Australia sime Canberra
Hi Chandansha, please review your testing process. I can see 3 issues just looking quickly. It needs:
- a rebase (merge conflict),
- " SKIP_PHPCS: '1'" turned on per #12
- the maintainer left a dozen comments to be resovled
- First commit to issue fork.
- 🇮🇳India ankitv18
Enabled a phpcs for gitlab pipeline. Now will fix the reported issues accordingly.
- Assigned to ankitv18
- 🇮🇳India ankitv18
ankitv18 → changed the visibility of the branch 3339820-drupal-coding-standards to hidden.
- Issue was unassigned.
- Status changed to Needs review
about 14 hours ago 12:59pm 25 June 2024