Drupal Coding Standards Issues | phpcs

Created MR , please review.

Thank you.

I will review it.

Thanks for this contribution Jay, the purpose of the phpcs rules is to prompt us to write good documentation. What exists here at the moment is filler.

If you can properly document the code, perhaps in collaboration with Indra, then it will be something worth adding to the codebase.

Take your time, use the module and follow it with a step-debugger, look at what the variables, methods and classes do and represent then put that in the documentation.

In line with my new policy to only provide credit for code standards updates where the user has not already been provided with a credit for such changes, I am removing credit from this issue.

Now that GitLab is being implemented I'm going to retract #8. Credit will be supplied for contributing to successfully getting the phpcs job to run and pass with *relevant* changes in line with #6. The pipeline will be available once 📌 Gitlab integration Needs review is committed.

I've updated the issue summary.

Once gitlab CI yaml 📌 Gitlab integration Needs review is in you'll need to rebase and remove the " SKIP_PHPCS: '1'" line.

amanmansuri72 → made their first commit to this issue’s fork.

Fixed remaining issues of PHPCS

I have tested MR 14 and cannot find any phpcs issue so I move forward to RTBC.

Hi Chandansha, please review your testing process. I can see 3 issues just looking quickly. It needs:

• a rebase (merge conflict),
• " SKIP_PHPCS: '1'" turned on per #12
• the maintainer left a dozen comments to be resovled

Enabled a phpcs for gitlab pipeline. Now will fix the reported issues accordingly.

ankitv18 → changed the visibility of the branch 3339820-drupal-coding-standards to hidden.

MR!11 is ready for a review.

@ankitv18 looks pretty good, thank you. There's just a matter of the new CSpell error due to a mispelled word in one of the comments.

@darvanen I have already fixed that see@https://git.drupalcode.org/issue/graphql_address-3339820/-/pipelines/208290

So I see, thank you, I got waylaid half way through my comment, great work.

Automatically closed - issue fixed for 2 weeks with no activity.