- Issue created by @sime
- Status changed to Needs work
9 months ago 6:39am 10 April 2024 - 🇦🇺Australia sime Melbourne
Please note that i'm working on this, but doing a video of it, so yeah, not finished yet :)
- Status changed to Needs review
9 months ago 7:55am 10 April 2024 - 🇦🇺Australia sime Melbourne
I think that's hit a baseline.
https://git.drupalcode.org/issue/graphql_address-3439805/-/pipelines/142494
- Status changed to Needs work
9 months ago 9:48am 10 April 2024 - 🇦🇺Australia darvanen Sydney, Australia
Thanks for this @sime!
I'd rather not have a warning symbol on the module page just for phpcs failures, would you mind getting the pipeline to skip that job? When this is all green and committed we can open follow-ups for any remaining tasks and call it fixed :)
- 🇦🇺Australia darvanen Sydney, Australia
I forgot, there's already a phpcs issue open: 🐛 Drupal Coding Standards Issues | phpcs Needs work
Do we need any other follow-ups? Maybe one to raise the PHPStan level?
- Status changed to Needs review
9 months ago 2:30pm 10 April 2024 - 🇦🇺Australia sime Melbourne
> Do we need any other follow-ups? Maybe one to raise the PHPStan level?
It couldn't hurt to have an issue for it, remain open on the issue about the level that might be reached. - Status changed to Needs work
8 months ago 6:45am 14 April 2024 - 🇦🇺Australia darvanen Sydney, Australia
Very surprised to see the official template gets the 'no new line at end of file' complaint. Shall we follow your suggestion in the IS about that?
Happy to keep the neon file because there's an ignore by error type in there rather than for entire files.
-
darvanen →
committed 9d1718da on 2.x authored by
sime →
Issue #3439805 by sime, darvanen: Gitlab integration
-
darvanen →
committed 9d1718da on 2.x authored by
sime →
- Status changed to Fixed
8 months ago 12:26pm 14 April 2024 - 🇦🇺Australia darvanen Sydney, Australia
Thanks @sime :)
Follow-up for PHPStan here, tagged Novice: 📌 Increase PHPStan level Active
Automatically closed - issue fixed for 2 weeks with no activity.