Gitlab integration

Created on 10 April 2024, 9 months ago
Updated 28 April 2024, 8 months ago

Problem/Motivation

This issue is to add gitlab CI to this module.

Proposed resolution

I've just added a super baseline configuration. It uses
* default gitlab-ci.yml
* fixes a tiny cspell error
* default phpstan.neon (what you get if you don't have one), ready to start increasing from level 0

For consideratoin
* you don't need the phpstan.neon file if you just want to use the default one
* Some people might strip out the comments from the gitlab-ci.yml template, but i just used a direct copy of the offiicial template.

The outcome is that phpcs is failing, but the others are passing. phpcs should be a follow up ticket.

📌 Task
Status

Fixed

Version

2.0

Component

Code

Created by

🇦🇺Australia sime Melbourne

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @sime
  • Merge request !8Initial gitlab configuration. → (Merged) created by sime
  • Pipeline finished with Success
    9 months ago
    Total: 137s
    #142418
  • Status changed to Needs work 9 months ago
  • 🇦🇺Australia sime Melbourne

    Please note that i'm working on this, but doing a video of it, so yeah, not finished yet :)

  • Pipeline finished with Success
    9 months ago
    Total: 139s
    #142476
  • Pipeline finished with Success
    9 months ago
    Total: 138s
    #142480
  • Pipeline finished with Success
    9 months ago
    Total: 170s
    #142489
  • Pipeline finished with Success
    9 months ago
    Total: 229s
    #142494
  • Status changed to Needs review 9 months ago
  • 🇦🇺Australia sime Melbourne
  • 🇦🇺Australia sime Melbourne
  • Status changed to Needs work 9 months ago
  • 🇦🇺Australia darvanen Sydney, Australia

    Thanks for this @sime!

    I'd rather not have a warning symbol on the module page just for phpcs failures, would you mind getting the pipeline to skip that job? When this is all green and committed we can open follow-ups for any remaining tasks and call it fixed :)

  • 🇦🇺Australia darvanen Sydney, Australia

    I forgot, there's already a phpcs issue open: 🐛 Drupal Coding Standards Issues | phpcs Needs work

    Do we need any other follow-ups? Maybe one to raise the PHPStan level?

  • Pipeline finished with Success
    9 months ago
    Total: 205s
    #142922
  • Pipeline finished with Success
    9 months ago
    Total: 166s
    #142925
  • Status changed to Needs review 9 months ago
  • 🇦🇺Australia sime Melbourne
  • 🇦🇺Australia sime Melbourne

    > Do we need any other follow-ups? Maybe one to raise the PHPStan level?
    It couldn't hurt to have an issue for it, remain open on the issue about the level that might be reached.

  • Status changed to Needs work 8 months ago
  • 🇦🇺Australia darvanen Sydney, Australia

    Very surprised to see the official template gets the 'no new line at end of file' complaint. Shall we follow your suggestion in the IS about that?

    Happy to keep the neon file because there's an ignore by error type in there rather than for entire files.

  • Pipeline finished with Success
    8 months ago
    Total: 147s
    #146093
  • Pipeline finished with Skipped
    8 months ago
    #146290
  • Status changed to Fixed 8 months ago
  • 🇦🇺Australia darvanen Sydney, Australia

    Thanks @sime :)

    Follow-up for PHPStan here, tagged Novice: 📌 Increase PHPStan level Active

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024