- Issue created by @darvanen
- First commit to issue fork.
- 🇦🇺Australia darvanen Sydney, Australia
@amanmansuri72 this issue is for phpstan, not phpcs. That effort belongs on 🐛 Drupal Coding Standards Issues | phpcs Needs work .
- First commit to issue fork.
- 🇲🇦Morocco h_kac
Hello,
I fixed some errors shown at level 2 to level 6 can u check that ?For the error below, I have checked the interface containing the signature of the function "get" we have only one param "CountryCode", I think we should remove the second param in the class
------ ------------------------------------------------------------------------------- Line src/Plugin/GraphQL/DataProducer/AddressFormatRepository.php ------ ------------------------------------------------------------------------------- 98 Method CommerceGuys\Addressing\AddressFormat\AddressFormatRepositoryInterface::get() invoked with 2 parameters, 1 required. ------ -------------------------------------------------------------------------------
What do you think ?
- Status changed to Needs work
2 days ago 2:21am 24 June 2024 - 🇦🇺Australia darvanen Sydney, Australia
Hi h_kac, if you would like work to be reviewed, please open a MR and set the issue to 'Needs Review' :)
- Status changed to Needs review
2 days ago 8:28am 24 June 2024 - Status changed to Needs work
1 day ago 1:00pm 24 June 2024 - 🇮🇳India ankitv18
Changes in the MR aren't seems to be phpstan related.
cc: @darvanen
- 🇦🇺Australia darvanen Sydney, Australia
- Status changed to Needs review
about 11 hours ago 4:00pm 25 June 2024