- Issue created by @Lendude
- 🇳🇱Netherlands Lendude Amsterdam
Here we go, this makes these strings translatable.
- Status changed to Needs work
almost 2 years ago 5:50pm 13 February 2023 - 🇺🇸United States smustgrave
Could we add a simple test case to show those fields are now translatable?
Also will this require an update path for existing sites or no since it's updating the schema not adding new values?
- Status changed to Needs review
almost 2 years ago 9:18am 14 February 2023 - 🇳🇱Netherlands Lendude Amsterdam
@smustgrave thanks for the review!
We generally don't do tests for these schema type changes, since the test would be testing the translation interface and not so much the change we are making here (they are also very hard to test properly). With that in mind, I've changed this to a task and not a bug.
It does indeed need an update to clear the schema cache, so added that.
- Status changed to Needs work
almost 2 years ago 4:34pm 14 February 2023 - 🇺🇸United States smustgrave
Seems to have a build failure
error: patch failed: core/modules/views/views.post_update.php:63
error: core/modules/views/views.post_update.php: patch does not apply - 🇳🇱Netherlands Lendude Amsterdam
Ah, I rolled it against 10.1, lets stick it in there first, worry about backports later
- Status changed to Needs review
almost 2 years ago 7:06am 16 February 2023 - Status changed to Needs work
almost 2 years ago 12:11pm 16 February 2023 - Status changed to Needs review
almost 2 years ago 11:44am 17 February 2023 - 🇮🇳India mrinalini9 New Delhi
Rerolled patch #8 for 10.1.x branch, please review it.
Thanks & Regards,
Mrinalini - Status changed to RTBC
almost 2 years ago 5:04pm 20 February 2023 - Status changed to Fixed
over 1 year ago 1:50pm 24 February 2023 -
longwave →
committed 7e8f000e on 10.1.x
Issue #3336414 by Lendude, Gauravvv, mrinalini9, smustgrave: Views...
-
longwave →
committed 7e8f000e on 10.1.x
- 🇬🇧United Kingdom longwave UK
Committed and pushed to 10.1.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.