- ๐ฎ๐ณIndia Charchil Khandelwal
Charchil Khandelwal โ made their first commit to this issueโs fork.
- Assigned to Charchil Khandelwal
- Status changed to Needs work
almost 2 years ago 9:02am 2 February 2023 - ๐ฎ๐ณIndia Charchil Khandelwal
FILE: ...taxonomy_machine_name\search_api_taxonomy_machine_name.views.inc
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
21 | WARNING | Unused variable $field_alias.
----------------------------------------------------------------------FILE: ...ne_name\src\Plugin\views\filter\SearchApiTaxonomyMachineName.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
77 | WARNING | Line exceeds 80 characters; contains 111 characters
204 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait
| | and $this->t() instead
----------------------------------------------------------------------FILE: ...ine_name\src\Plugin\views\argument_validator\TermMachineName.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
74 | WARNING | Unused variable $operator.
78 | WARNING | Unused variable $operator.
----------------------------------------------------------------------FILE: ...achine_name\src\Plugin\views\filter\TaxonomyIndexMachineName.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
279 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait
| | and $this->t() instead
----------------------------------------------------------------------Need to fix these issues.
- @charchil-khandelwal opened merge request.
- ๐ฎ๐ณIndia Charchil Khandelwal
All the errors and warnings are fixed now.
Created MR for this issue.
Please review.Thank you.
- Issue was unassigned.
- ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command has been used, which arguments have been used, and which report that command shown.
- Status changed to Needs review
over 1 year ago 8:07am 14 June 2023 - Status changed to Needs work
over 1 year ago 9:35am 14 June 2023 - Assigned to nitin_lama
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 11:12am 15 June 2023 - Status changed to Fixed
over 1 year ago 1:59pm 20 June 2023 - ๐จ๐ฆCanada joseph.olstad
I took the first patch, with that said, next time please focus on phpcs instead of everything all at once.
-
joseph.olstad โ
committed 20765c7a on 8.x-1.x authored by
noorulshameera โ
Issue #3335072 by Charchil Khandelwal, nitin_lama, noorulshameera,...
-
joseph.olstad โ
committed 20765c7a on 8.x-1.x authored by
noorulshameera โ
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
9 months ago 9:49am 19 March 2024 - ๐ง๐ชBelgium BramDriesen Belgium ๐ง๐ช
I don't understand how this was OK to merge. Fixing PHPCS issues should NOT introduce breaking changes in a minor version release...
- Status changed to Active
9 months ago 1:43am 20 March 2024 - ๐จ๐ฆCanada joseph.olstad
Yes, I must have been half awake that day taking that patch. With that said, 2.0.0 has been out for a long while and was a Drupal 10 compatibility release and this merge request had some fixes for deprecations.
- Status changed to Fixed
9 months ago 1:55am 20 March 2024 Automatically closed - issue fixed for 2 weeks with no activity.