- First commit to issue fork.
- Status changed to Needs review
over 1 year ago 5:26am 23 January 2023 - 🇮🇳India Gauravvv Delhi, India
When announcement off-canvas dialog is open, container is taking the wrong width. I have fixed that and provided the patch, Please review.
- 🇮🇪Ireland markconroy
The patch applies cleanly, and seems to fix the issue. However, it does create a very small layout shift.
If Olivero maintainers are okay with this small shift (it's about 6px), I think this could be marked RTBC.
Before:
After:
- Status changed to Needs work
over 1 year ago 5:09pm 14 February 2023 - 🇺🇸United States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.
This could use an issue summary update. Proposed solution is empty, obviously the goal is to fix it but how was it being fixed?
Before/after screenshots should be added to the IS also. - 🇺🇸United States andy-blum Ohio, USA
Unfortunately, I think this approach will not work. Between the range of screen widths that show the mobile menu (including the desktop version in some configurations), and the resizability of the off-canvas menu, I don't think we want the menu button to move at all, unless the entire slide-out menu moves with it to avoid situations where the menu button leaves it's visual (but not DOM) container as in the screenshot below (patch #4 applied along with MR #2889 from [
#3206643])Because of the interactions between the offcanvas dialog and the navigation, I'm adding the needs accessibility review tag
- @andy-blum opened merge request.
- Status changed to Needs review
over 1 year ago 3:55pm 17 February 2023 - Assigned to Guru2023
- 🇮🇳India Guru2023
I will review this patch and confirm the same. Is it working fine or not
- Issue was unassigned.
- Status changed to RTBC
over 1 year ago 11:31am 21 February 2023 - 🇮🇳India Guru2023
Reviewed the patch #4 and tested it on Drupal version 10.1.x. The patch works fine and I have added the before and after screenshot for reference.
- 🇮🇳India rckstr_rohan
Reviewed MR !3490, on comment #9 , issue has been fixed, can be merged.
- 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Adding credits
i don't think this needs an a11y review as its just CSS changes
-
larowlan →
committed 1d34ad2e on 10.0.x
Issue #3334907 by andy-blum, Gauravvvv, Guru2023, markconroy, shaal:...
-
larowlan →
committed 1d34ad2e on 10.0.x
-
larowlan →
committed be918cb0 on 10.1.x
Issue #3334907 by andy-blum, Gauravvvv, Guru2023, markconroy, shaal:...
-
larowlan →
committed be918cb0 on 10.1.x
- Status changed to Downport
over 1 year ago 3:45am 31 March 2023 - 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Committed to 10.1.x and 10.0.x
Does not apply to 9.5.x so marking as patch (to be ported)
- 🇮🇳India Gauravvv Delhi, India
I have added patch for 9.5.x. but I see a problem while compiling the patch. This CSS code
transform: translateX(calc(-100% - var(--drupal-displace-offset-right, 0px))); /* LTR */
is compiled intotransform: translateX(-100%); /* LTR */
which seems to be an issue for me. I seecalc()
function is calculating on the compilation time only, noticed that for other units as well. this is happening in 9.5.x only not on 10.1.x - Status changed to Fixed
over 1 year ago 9:46am 26 May 2023 - 🇬🇧United Kingdom catch
@Gauravvv that is probably due to Drupal 9's supported browsers. If this is complex to backport, I think we should leave it in 10.0.x.
Automatically closed - issue fixed for 2 weeks with no activity.