- ๐ฎ๐ณIndia gauravvvv Delhi, India
Gauravvv โ made their first commit to this issueโs fork.
- Status changed to Needs review
almost 2 years ago 5:13am 7 February 2023 - ๐ฎ๐ณIndia gauravvvv Delhi, India
Refactored
system-admin--links.pcss.css
file.1. Improved nesting of selectors.
2. No changes insystem-admin--links.css
file, so we're good to review. - Status changed to RTBC
almost 2 years ago 11:44pm 19 February 2023 - ๐บ๐ธUnited States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request โ as a guide.
Change looks good.
All nesting is done
.css is unchanged so no screenshots are needed.
- Status changed to Needs work
almost 2 years ago 8:00am 20 February 2023 - ๐ซ๐ฎFinland lauriii Finland
+++ b/core/themes/claro/css/components/system-admin--links.pcss.css @@ -13,11 +13,15 @@ +small { + & .admin-link {
I think this would be more readable if we had this only nested on two levels. First level would be
small .admin-link
and then we have the&:before
and&:after
inside it. - Status changed to Needs review
almost 2 years ago 8:41am 20 February 2023 - ๐ฎ๐ณIndia gauravvvv Delhi, India
Thankyou for quick feedback @Lauri. I agree with you. I have updated the patch with required changes. please review
- Status changed to RTBC
almost 2 years ago 4:12pm 20 February 2023 -
lauriii โ
committed 7c9320bf on 10.1.x
Issue #3332445 by Gauravvv, smustgrave: Refactor Claro's system-admin--...
-
lauriii โ
committed 7c9320bf on 10.1.x
- Status changed to Fixed
almost 2 years ago 4:36pm 20 February 2023