Use chaining for User::addRole() and ::removeRole()

I've addressed #9 and made a separate MR based on 10.1.x (previous one has to be rebased).

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

I feel bad that I made that commit accidentally and confused the review bot. How can we make the MR by @pminf the one the bot reacts to?

@rogerpfaff I reverted your commit from #25 and set the issue back to its previous state. Tests will pass and everything will be OK again :)

I made a rebase.

Before reviewing there appear to be some merge conflicts

error: patch failed: core/modules/block_content/tests/src/Kernel/BlockContentAccessHandlerTest.php:116
error: core/modules/block_content/tests/src/Kernel/BlockContentAccessHandlerTest.php: patch does not apply
error: patch failed: core/modules/user/tests/src/Kernel/UserEntityReferenceTest.php:67
error: core/modules/user/tests/src/Kernel/UserEntityReferenceTest.php: patch does not apply

Hi, I applied the patch after rebasing the branch, it seems look good, it is getting applied cleanly without any conflict, Attaching screenshot, Other than that patch look fine, there is no other User role method seen got unchained.

I'm going to claim this issue so that I can use it for the DrupalCon Portland core mentoring day.

-mike

Working on this issue at `#drupalconpdx` with and `#chadhester` and `#Zoyace Shrestha` `#first-contribution` with guidance from `#ultimike`

We spent 1200 to 1500 May 8 2024 porting the merge request from Drupal 10 to Drupal 11.

ultimike → changed the visibility of the branch 11.x to hidden.

ultimike → changed the visibility of the branch 10.1.x to hidden.

ultimike → changed the visibility of the branch 3331229-use-chaining-for-rebased to hidden.

ultimike → changed the visibility of the branch 3331229-use-chaining-for to hidden.

Looks good to me.

Worked on the issue with @ultimike at DrupalCon Portland 2024.

Worked on this with three mentees during DrupalCon Portland 2024 first time contributor workshop: @Zoyace Shrestha, @chadhester,
@alexb7217

-mike

Saving DrupalCon contributor credits from #45.

And hiding screenshot. (We only need screenshots when there is a user-facing change to evaluate.) Thanks!

Committed live! at DrupalCon Portland 2024 to 11.x, 11.0.x, 10.4.x, and 10.3.x. It did not cherry-pick cleanly to 10.2.x. Setting PTBP for a 10.2.x MR.

Thanks everyone!

10.2.x has had its final bugfix release, so marking fixed against 10.3.x (which means those credits from Portland will finally show on your profiles.) 😅 Yay!

w00t. Thank you.

Automatically closed - issue fixed for 2 weeks with no activity.