Munich
Account created on 18 September 2006, over 18 years ago
#

Recent comments

πŸ‡©πŸ‡ͺGermany rogerpfaff Munich

There is now a MR to fix this.

It's only changing the index value to target_id if you want to quick fix this in your install. See the code block marked with >>> above.

πŸ‡©πŸ‡ͺGermany rogerpfaff Munich

Also the module is basically unusable with this error so setting this to critical.

πŸ‡©πŸ‡ͺGermany rogerpfaff Munich

Taking a deeper look I think there must be a change in return values somewhere? The code does not look like it could work as the return values that get checked are not keyed with 'value' but target_id.

The code in question is this one

            case 'shared':  //allow if user shares a value is in this field

                $user = User::load(\Drupal::currentUser()->id());
                $user_field = $config->getExtra();
                $user_field_values =  $user->get($user_field)->getValue();

                foreach($node_field_value as $value){
                    foreach($user_field_values as $uvalue){
>>>                    if($value['value'] == $uvalue['value'] ){
                            $control_entity = $user;
                            $grant_access_read = $config_bool_read ? true : false;
                            $grant_access_update = $config_bool_update ? true : false;
                            $grant_access_delete = $config_bool_delete ? true : false;
                            break;
                        }
                    }
                }
                break;

The arrays $node_field_value and $user_field_values look like this

$node_field_value
Array
(
    [0] => Array
        (
            [target_id] => 26
        )

)
$user_field_values
Array
(
    [0] => Array
        (
            [target_id] => 25
        )

    [1] => Array
        (
            [target_id] => 26
        )

)
πŸ‡©πŸ‡ͺGermany rogerpfaff Munich

Can confirm this on 3.0.3

πŸ‡©πŸ‡ͺGermany rogerpfaff Munich

The exported JSON export

{
    "uuid": [
        {
            "value": "cbd4523b-7178-4755-8935-708bec8026ac"
        }
    ],
    "langcode": [
        {
            "value": "en"
        }
    ],
    "queue": [
        {
            "target_id": "alumni",
            "target_type": "entity_queue",
            "target_uuid": "77e98bfc-6d0c-431e-9728-e1e65efe941d"
        }
    ],
    "revision_created": [
        {
            "value": "2024-10-01T11:45:35+00:00",
            "format": "Y-m-d\\TH:i:sP"
        }
    ],
    "revision_user": [
        {
            "target_type": "user",
            "target_uuid": "b3698473-8910-4907-93b4-1936c0a80cb8"
        }
    ],
    "revision_log_message": [],
    "status": [
        {
            "value": true
        }
    ],
    "uid": [
        {
            "target_type": "user",
            "target_uuid": "b3698473-8910-4907-93b4-1936c0a80cb8"
        }
    ],
    "title": [
        {
            "value": "Alumni"
        }
    ],
    "items": [
        {
            "target_type": "node",
            "target_uuid": "91b4f754-a630-48a0-9127-d1340062ed29"
        },
        {
            "target_type": "node",
            "target_uuid": "54da8024-9ae9-48a9-98bc-b65f85ba2a02"
        },
        {
            "target_type": "node",
            "target_uuid": "22d6986f-49aa-44bd-a1aa-140c43081e7d"
        },
        {
            "target_type": "node",
            "target_uuid": "1cabb8a5-4daf-4c39-a841-e31dfe3144a3"
        },
        {
            "target_type": "node",
            "target_uuid": "cdc111ee-f835-4151-99dd-508b88e69baa"
        },
        {
            "target_type": "node",
            "target_uuid": "f9919b22-8442-4e35-ac46-50823267bd70"
        },
        {
            "target_type": "node",
            "target_uuid": "3b7b1684-d6dc-4816-af1d-4ba222c818aa"
        },
        {
            "target_type": "node",
            "target_uuid": "2cc0416e-601c-4411-b9ab-331d152fb142"
        },
        {
            "target_type": "node",
            "target_uuid": "a600f102-bd16-4d1f-a41c-dfd9b7ef926d"
        },
        {
            "target_type": "node",
            "target_uuid": "a218ac8c-8f40-4f34-a8c2-4e5a5c19499d"
        },
        {
            "target_type": "node",
            "target_uuid": "f33e10b7-45b4-4774-9b47-79fb929e56c4"
        },
        {
            "target_type": "node",
            "target_uuid": "119199dc-c42d-4428-8473-2513c238cc07"
        },
        {
            "target_type": "node",
            "target_uuid": "f3496a5e-7739-4014-b195-58069ba0fbf2"
        },
        {
            "target_type": "node",
            "target_uuid": "088c429b-a9d3-4b3b-8f8f-24ab2bf7c7b8"
        },
        {
            "target_type": "node",
            "target_uuid": "7b4eb5ed-a871-4a3d-9cd3-a83fecb8ae25"
        },
        {
            "target_type": "node",
            "target_uuid": "a0726807-7c2e-4f7a-beaf-d587d1074adb"
        },
        {
            "target_type": "node",
            "target_uuid": "8c8e8682-b14e-4c01-9c09-82500d79849a"
        },
        {
            "target_type": "node",
            "target_uuid": "b5d17bf1-b6a9-4a6e-ae82-81583755dfaa"
        },
        {
            "target_type": "node",
            "target_uuid": "8c584233-d4a8-4cc9-ac66-67f3b5f41d60"
        },
        {
            "target_type": "node",
            "target_uuid": "3b9656e3-938d-4183-ace9-e56e201cbdac"
        }
    ],
    "created": [
        {
            "value": "2024-10-01T11:45:35+00:00",
            "format": "Y-m-d\\TH:i:sP"
        }
    ],
    "changed": [
        {
            "value": "2024-10-01T12:04:48+00:00",
            "format": "Y-m-d\\TH:i:sP"
        }
    ],
    "default_langcode": [
        {
            "value": true
        }
    ],
    "revision_translation_affected": [
        {
            "value": true
        }
    ]
}

There is no name field like in #3106819: Error while importing Node Queues in D8 β†’

πŸ‡©πŸ‡ͺGermany rogerpfaff Munich

By just copy pasting it works. Area is calculated. No errors in console. Looks good to merge for me.

πŸ‡©πŸ‡ͺGermany rogerpfaff Munich

A look into the entity definition of the entityqueue module shows in src/Entity/EntitySubqueue.php

entity_keys = {
 *     "id" = "name",
 *     "revision" = "revision_id",
 *     "bundle" = "queue",
 *     "label" = "title",
 *     "langcode" = "langcode",
 *     "uuid" = "uuid",
 *     "owner" = "uid",
 *     "published" = "status",
 *   },

I think this is where the break happens. Should entityqueue module adapt this or tome handle it?

πŸ‡©πŸ‡ͺGermany rogerpfaff Munich

One more addition to the token thing if anybody is struggeling: It's not Drupal tokens but tokens with swirly brackets {}.

πŸ‡©πŸ‡ͺGermany rogerpfaff Munich

Apparently it was not this module but webform itself that didn't save.

πŸ‡©πŸ‡ͺGermany rogerpfaff Munich

Little OT: Cleaning up messed branches is not supported but maybe hidable in the future #3204376: How to remove branch from an issue fork β†’

πŸ‡©πŸ‡ͺGermany rogerpfaff Munich

Edit: Making the title clearer

πŸ‡©πŸ‡ͺGermany rogerpfaff Munich

Uhm. I messed up the issue fork I think, so I'm not opening a MR at this point as I don't know what happens then to the main branch I commited to in the fork. I'd be glad taking advice on how to fix this.

πŸ‡©πŸ‡ͺGermany rogerpfaff Munich

Thanks for the hint. Closing this as duplicate.

πŸ‡©πŸ‡ͺGermany rogerpfaff Munich

I feel bad that I made that commit accidentally and confused the review bot. How can we make the MR by @pminf the one the bot reacts to?

πŸ‡©πŸ‡ͺGermany rogerpfaff Munich

rogerpfaff β†’ made their first commit to this issue’s fork.

Production build 0.71.5 2024