Contrib.social

Update formatting as per Drupal coding standards

Open on Drupal.org ā†’
Created on 5 January 2023, almost 2 years ago
Updated 16 August 2024, 3 months ago

The code contains basic formatting issues which should be fixed.

  1. Lines longer than 80 characters
  2. @todo messages that do not follow the standard message
  3. Missing commas
  4. Lines not correctly indented
šŸ“Œ Task
Status

Needs review

Version

1.0

Component

Core integration

Created by

šŸ‡®šŸ‡³India sahil.goyal

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment almost 2 years ago ā†’
    šŸ‡®šŸ‡³India ayush.khare

    Fixed #2.

  • First commit to issue fork.
  • Comment almost 2 years ago ā†’
    šŸ‡®šŸ‡³India sidharth_soman Bangalore

    @ayush.khare's patch applied cleanly and resolved most of the errors. The only ones remaining are array indentation and doc comment formatting stuff along with some unused variables. If it's better to leave the indentation and formatting as it is for readability purposes, then I think this is good enough for RTBC. Waiting for a confirmation, @TR.

  • Assigned to himanshu_jhaloya
  • Comment almost 2 years ago ā†’
    šŸ‡®šŸ‡³India himanshu_jhaloya Indore
  • Comment almost 2 years ago ā†’
    šŸ‡®šŸ‡³India himanshu_jhaloya Indore

    Improved the code phpcs

  • Issue was unassigned.
  • Comment almost 2 years ago ā†’
    šŸ‡®šŸ‡³India himanshu_jhaloya Indore
  • Comment almost 2 years ago ā†’
    šŸ‡®šŸ‡³India nayana_mvr

    Verified the patch #8 and tested it on Drupal version 10.1.x and Entity version 8.x-1.x. The patch works fine and all the coding standard issues shown in the attached file were fixed after applying the patch. RTBC+1

  • Comment almost 2 years ago ā†’
    šŸ‡®šŸ‡³India nayana_mvr
  • Status changed to Needs work over 1 year ago
  • Comment over 1 year ago ā†’
    šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹

    The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command has been used, which arguments have been used, and which report that command shown.

  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago ā†’
    šŸ‡®šŸ‡³India Ashutosh Ahirwal India

    Issue summary updated please review.

  • Status changed to Needs work over 1 year ago
  • Comment over 1 year ago ā†’
    šŸ‡ŗšŸ‡øUnited States tr Cascadia

    The issue summary is quite wrong still. Read what I said in #3.

    While there are some changes in the patch that are ready to commit, most of the patch is still not ready for the reasons I spelled out in #3. And specifically, because all these unrelated issues are lumped together into one big patch, it can't be committed until all the things are fixed.

    Coding standards can point out things that need to be improved, like missing documentation comments. But the proper fix is NEVER to just put an empty or placeholder comment in there to make the errors go away. If the documentation comment is missing, then write the documentation. If the class is missing a class documentation comment, don't just put in the class name - that doesn't give us any information we don't already know, does not help anyone trying to understand the code, etc. It just makes the error disappear, which ensures that no one will every go back and fix it. If you're going to add documentation comments, do it right or not at all.

  • Assigned to RohitRawat676
  • Status changed to Active over 1 year ago
  • Comment over 1 year ago ā†’
    šŸ‡®šŸ‡³India RohitRawat676
  • Issue was unassigned.
  • Status changed to Needs review over 1 year ago
  • Open in Jenkins ā†’ Open on Drupal.org ā†’
    Core: 9.5.5 + Environment: PHP 7.3 & MySQL 5.7
    last update over 1 year ago
    149 pass
  • Comment over 1 year ago ā†’
    šŸ‡®šŸ‡³India RohitRawat676
  • Status changed to Needs work over 1 year ago
  • Comment over 1 year ago ā†’
    šŸ‡ŗšŸ‡øUnited States tr Cascadia

    Please read what I wrote in #14.

  • Assigned to capysara
  • Comment 11 months ago ā†’
    šŸ‡ŗšŸ‡øUnited States capysara
  • Comment 11 months ago ā†’
    šŸ‡ŗšŸ‡øUnited States capysara
  • Comment 11 months ago ā†’
    šŸ‡ŗšŸ‡øUnited States capysara
  • Merge request !29Updated formatting for coding standards. ā†’ (Open) created by capysara
  • Open in Jenkins ā†’ Open on Drupal.org ā†’
    Core: 9.5.5 + Environment: PHP 7.3 & MySQL 5.7
    last update 11 months ago
    149 pass
  • Open in Jenkins ā†’ Open on Drupal.org ā†’
    Core: 9.5.x + Environment: PHP 8.0 & MySQL 5.7
    last update 11 months ago
    149 pass
  • Open in Jenkins ā†’ Open on Drupal.org ā†’
    Core: 10.1.x + Environment: PHP 8.2 & MySQL 8
    last update 11 months ago
    149 pass
  • Open in Jenkins ā†’ Open on Drupal.org ā†’
    Core: 10.1.4 + Environment: PHP 8.1 & MariaDB 10.3.22
    last update 11 months ago
    149 pass
  • Open in Jenkins ā†’ Open on Drupal.org ā†’
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 8
    last update 11 months ago
    149 pass
  • Open in Jenkins ā†’ Open on Drupal.org ā†’
    Core: 9.5.5 + Environment: PHP 7.3 & MySQL 5.7
    last update 11 months ago
    149 pass
  • Issue was unassigned.
  • Status changed to Needs review 11 months ago
  • Comment 11 months ago ā†’
    šŸ‡ŗšŸ‡øUnited States capysara

    Added MR for minor formatting updates.
    Hiding patches to avoid confusion.

  • Open in Jenkins ā†’ Open on Drupal.org ā†’
    Core: 9.5.5 + Environment: PHP 7.3 & MySQL 5.7
    last update 11 months ago
    149 pass
  • Open in Jenkins ā†’ Open on Drupal.org ā†’
    Core: 10.1.x + Environment: PHP 8.2 & MySQL 8
    last update 11 months ago
    149 pass
  • Open in Jenkins ā†’ Open on Drupal.org ā†’
    Core: 9.5.5 + Environment: PHP 7.3 & MySQL 5.7
    last update 11 months ago
    149 pass
  • Open in Jenkins ā†’ Open on Drupal.org ā†’
    Core: 10.1.x + Environment: PHP 8.2 & MySQL 8
    last update 11 months ago
    149 pass
  • Status changed to Needs work 3 months ago
  • Comment 3 months ago ā†’
    a.aaronjake

    Hi @everyone,

    Applied the changes committed on MR!29, some files failed to apply, might be the reason the errors below were reported. Please see:

    entity git:(8.x-1.x) curl https://git.drupalcode.org/project/entity/-/merge_requests/29.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 24110    0 24110    0     0  12420      0 --:--:--  0:00:01 --:--:-- 12505
patching file README.txt
patching file entity.module
patching file src/Access/EntityRevisionRouteAccessChecker.php
patching file src/Controller/RevisionOverviewController.php
patching file src/EntityViewsData.php
patching file src/Form/RevisionRevertForm.php
patching file src/Form/RevisionableContentEntityForm.php
patching file tests/src/Functional/Menu/EntityLocalTaskTest.php
patching file tests/src/Kernel/BundlePluginTest.php
patching file tests/src/Kernel/QueryAccess/EventOnlyQueryAccessHandlerTest.php
patching file tests/src/Kernel/QueryAccess/UncacheableQueryAccessHandlerTest.php
patching file tests/src/Unit/EntityAccessControlHandlerTest.php
Hunk #1 FAILED at 89.
Hunk #2 FAILED at 124.
Hunk #3 FAILED at 147.
Hunk #4 FAILED at 181.
Hunk #5 FAILED at 291.
5 out of 5 hunks FAILED -- saving rejects to file tests/src/Unit/EntityAccessControlHandlerTest.php.rej
patching file tests/src/Unit/UncacheableEntityAccessControlHandlerTest.php
Hunk #1 succeeded at 100 with fuzz 2 (offset 2 lines).
āžœ  entity git:(8.x-1.x) āœ— ..
āžœ  contrib git:(main) āœ— phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig entity

FILE: ...odules/entity_module_bundle_plugin_test/src/Plugin/BundlePluginTest/First.php
-----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong
   |       |     one is Drupal\Core\Plugin\PluginBase.
-----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------


FILE: .../modules/entity_module_bundle_plugin_test/src/Annotation/BundlePluginTest.php
-----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------
 30 | ERROR | The @var tag must be the first tag in a member variable comment
-----------------------------------------------------------------------------------


FILE: ...ity_module_bundle_plugin_examples_test/src/Plugin/BundlePluginTest/Second.php
-----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong
   |       |     one is Drupal\Core\Plugin\PluginBase.
-----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------


FILE: ...les/contrib/entity/tests/modules/entity_module_test/entity_module_test.module
-----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------
 1 | ERROR | [x] Missing file doc comment
-----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------


FILE: ...s/contrib/entity/tests/modules/entity_module_test/entity_module_test.info.yml
-----------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------
 1 | WARNING | "Description" property is missing in the info.yml file
-----------------------------------------------------------------------------------


FILE: ...ntrib/entity/tests/modules/entity_module_test/src/Form/EnhancedEntityForm.php
-----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------
 9 | ERROR | [x] Missing class doc comment
-----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------


FILE: ...ests/modules/entity_module_test/src/EventSubscriber/QueryAccessSubscriber.php
-----------------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
-----------------------------------------------------------------------------------
  10 | ERROR   | [x] Missing class doc comment
  97 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency
     |         |     injection instead
 101 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency
     |         |     injection instead
-----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------


FILE: ...odules/contrib/entity/tests/src/Unit/BundleEntityAccessControlHandlerTest.php
-----------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------
 9 | WARNING | [x] Unused use statement
-----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------


FILE: ...ue/web/modules/contrib/entity/tests/src/Unit/EntityPermissionProviderTest.php
-----------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------
 5 | WARNING | [x] Unused use statement
-----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------


FILE: .../web/modules/contrib/entity/tests/src/Unit/EntityAccessControlHandlerTest.php
-----------------------------------------------------------------------------------
FOUND 20 ERRORS AND 1 WARNING AFFECTING 17 LINES
-----------------------------------------------------------------------------------
  10 | WARNING | [x] Unused use statement
 117 | ERROR   | [ ] The array declaration extends to column 151 (the limit is
     |         |     120). The array content should be split up over multiple
     |         |     lines
 118 | ERROR   | [ ] The array declaration extends to column 154 (the limit is
     |         |     120). The array content should be split up over multiple
     |         |     lines
 128 | ERROR   | [ ] The array declaration extends to column 149 (the limit is
     |         |     120). The array content should be split up over multiple
     |         |     lines
 128 | ERROR   | [ ] The array declaration extends to column 148 (the limit is
     |         |     120). The array content should be split up over multiple
     |         |     lines
 129 | ERROR   | [ ] The array declaration extends to column 152 (the limit is
     |         |     120). The array content should be split up over multiple
     |         |     lines
 129 | ERROR   | [ ] The array declaration extends to column 151 (the limit is
     |         |     120). The array content should be split up over multiple
     |         |     lines
 130 | ERROR   | [ ] The array declaration extends to column 141 (the limit is
     |         |     120). The array content should be split up over multiple
     |         |     lines
 144 | ERROR   | [ ] The array declaration extends to column 130 (the limit is
     |         |     120). The array content should be split up over multiple
     |         |     lines
 145 | ERROR   | [ ] The array declaration extends to column 132 (the limit is
     |         |     120). The array content should be split up over multiple
     |         |     lines
 149 | ERROR   | [ ] The array declaration extends to column 132 (the limit is
     |         |     120). The array content should be split up over multiple
     |         |     lines
 150 | ERROR   | [ ] The array declaration extends to column 135 (the limit is
     |         |     120). The array content should be split up over multiple
     |         |     lines
 151 | ERROR   | [ ] The array declaration extends to column 121 (the limit is
     |         |     120). The array content should be split up over multiple
     |         |     lines
 154 | ERROR   | [ ] The array declaration extends to column 131 (the limit is
     |         |     120). The array content should be split up over multiple
     |         |     lines
 155 | ERROR   | [ ] The array declaration extends to column 133 (the limit is
     |         |     120). The array content should be split up over multiple
     |         |     lines
 156 | ERROR   | [ ] The array declaration extends to column 138 (the limit is
     |         |     120). The array content should be split up over multiple
     |         |     lines
 156 | ERROR   | [ ] The array declaration extends to column 137 (the limit is
     |         |     120). The array content should be split up over multiple
     |         |     lines
 159 | ERROR   | [ ] The array declaration extends to column 133 (the limit is
     |         |     120). The array content should be split up over multiple
     |         |     lines
 160 | ERROR   | [ ] The array declaration extends to column 135 (the limit is
     |         |     120). The array content should be split up over multiple
     |         |     lines
 161 | ERROR   | [ ] The array declaration extends to column 141 (the limit is
     |         |     120). The array content should be split up over multiple
     |         |     lines
 161 | ERROR   | [ ] The array declaration extends to column 140 (the limit is
     |         |     120). The array content should be split up over multiple
     |         |     lines
-----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------


FILE: ...issue/web/modules/contrib/entity/tests/src/Unit/QueryAccess/ConditionTest.php
-----------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
-----------------------------------------------------------------------------------
 15 | ERROR | Doc comment short description must start with a capital letter
 24 | ERROR | Doc comment short description must start with a capital letter
 27 | ERROR | Doc comment short description must be on a single line, further text
    |       | should be a separate paragraph
-----------------------------------------------------------------------------------


FILE: ...modules/contrib/entity/tests/src/Functional/BulkFormEntityListBuilderTest.php
-----------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-----------------------------------------------------------------------------------
  56 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
 137 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
 180 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
-----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------


FILE: ...rib/entity/tests/src/Kernel/QueryAccess/UncacheableQueryAccessHandlerTest.php
-----------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------
 46 | WARNING | Unused variable $admin_user.
-----------------------------------------------------------------------------------


FILE: ...es/contrib/entity/tests/src/Kernel/QueryAccess/UncacheableQueryAccessTest.php
-----------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------
 58 | WARNING | Unused variable $admin_user.
-----------------------------------------------------------------------------------


FILE: ...eb/modules/contrib/entity/tests/src/Kernel/QueryAccess/ConditionGroupTest.php
-----------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------
 21 | ERROR | Doc comment short description must start with a capital letter
 24 | ERROR | Doc comment short description must be on a single line, further text
    |       | should be a separate paragraph
-----------------------------------------------------------------------------------


FILE: ...odules/contrib/entity/tests/src/Kernel/QueryAccess/QueryAccessHandlerTest.php
-----------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------
 46 | WARNING | Unused variable $admin_user.
-----------------------------------------------------------------------------------


FILE: .../modules/contrib/entity/tests/src/Kernel/QueryAccess/QueryAccessEventTest.php
-----------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------
 39 | WARNING | Unused variable $admin_user.
-----------------------------------------------------------------------------------


FILE: ...e/web/modules/contrib/entity/tests/src/Kernel/QueryAccess/QueryAccessTest.php
-----------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------
 58 | WARNING | Unused variable $admin_user.
-----------------------------------------------------------------------------------


FILE: ...-orgissue/web/modules/contrib/entity/tests/src/Kernel/RevisionBasicUITest.php
-----------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
-----------------------------------------------------------------------------------
  11 | ERROR | [ ] Missing short description in doc comment
 124 | ERROR | [x] Missing function doc comment
 183 | ERROR | [x] Missing function doc comment
-----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------


FILE: ...metInterns/Demo-site/drupal-orgissue/web/modules/contrib/entity/entity.module
-----------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------
 77 | WARNING | [x] The variable name should be defined after the type
 78 | WARNING | [ ] Unused variable $entity_type_id.
-----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------


FILE: ...Interns/Demo-site/drupal-orgissue/web/modules/contrib/entity/entity.views.inc
-----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------
 1 | ERROR | [x] Missing file doc comment
-----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------


FILE: .../drupal-orgissue/web/modules/contrib/entity/src/BulkFormEntityListBuilder.php
-----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------
 39 | ERROR | The @var tag must be the first tag in a member variable comment
-----------------------------------------------------------------------------------


FILE: ...te/drupal-orgissue/web/modules/contrib/entity/src/Form/DeleteMultipleForm.php
-----------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
-----------------------------------------------------------------------------------
 12 | ERROR | The text '@deprecated Use
    |       | \Drupal\Core\Entity\Form\DeleteMultipleForm instead.' does not match
    |       | the standard format: @deprecated in %deprecation-version% and is
    |       | removed from %removal-version%. %extra-info%.
 12 | ERROR | Each @deprecated tag must have a @see tag immediately following it
-----------------------------------------------------------------------------------


FILE: ...rgissue/web/modules/contrib/entity/src/Form/RevisionableContentEntityForm.php
-----------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
-----------------------------------------------------------------------------------
 14 | ERROR | The text '@deprecated Use \Drupal\Core\Entity\ContentEntityForm
    |       | instead.' does not match the standard format: @deprecated in
    |       | %deprecation-version% and is removed from %removal-version%.
    |       | %extra-info%.
 14 | ERROR | Each @deprecated tag must have a @see tag immediately following it
-----------------------------------------------------------------------------------


FILE: ...te/drupal-orgissue/web/modules/contrib/entity/src/Form/RevisionRevertForm.php
-----------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
-----------------------------------------------------------------------------------
  10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong
     |       |     one is Drupal\Core\Entity\RevisionLogInterface.
  14 | ERROR | [x] Missing class doc comment
 170 | ERROR | [ ] Description for the @return value is missing
-----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------


FILE: ...ue/web/modules/contrib/entity/src/Access/EntityRevisionRouteAccessChecker.php
-----------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------
 19 | ERROR | [ ] Missing short description in doc comment
 60 | ERROR | [x] list(...) is forbidden, use [...] instead.
-----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------


FILE: ...e/web/modules/contrib/entity/src/Entity/RevisionableEntityBundleInterface.php
-----------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------
  9 | ERROR | Missing short description in doc comment
 10 | ERROR | The text '@deprecated in favor of
    |       | \Drupal\Core\Entity\RevisionableEntityBundleInterface. Use that
    |       | instead.' does not match the standard format: @deprecated in
    |       | %deprecation-version% and is removed from %removal-version%.
    |       | %extra-info%.
 10 | ERROR | Each @deprecated tag must have a @see tag immediately following it
-----------------------------------------------------------------------------------


FILE: ...rupal-orgissue/web/modules/contrib/entity/src/QueryAccess/ViewsQueryAlter.php
-----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------
 167 | ERROR | [x] list(...) is forbidden, use [...] instead.
-----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------


FILE: ...upal-orgissue/web/modules/contrib/entity/src/QueryAccess/QueryAccessEvent.php
-----------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------
  6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong
    |       |     one is Drupal\Component\EventDispatcher\Event.
 64 | ERROR | [ ] The trigger_error message 'The $entity_type_id argument must be
    |       |     passed to QueryAccessEvent::__construct(), it is required before
    |       |     entity:2.0.0. See https://www.drupal.org/node/3134363.' does not
    |       |     match the relaxed standard format: %thing% is deprecated in
    |       |     %deprecation-version% any free text %removal-version%.
    |       |     %extra-info%. See %cr-link%
-----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------


FILE: ...issue/web/modules/contrib/entity/src/Plugin/Derivative/EntityTasksDeriver.php
-----------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------
 44 | WARNING | Unused variable $entity_type_id.
-----------------------------------------------------------------------------------


FILE: ...sue/web/modules/contrib/entity/src/Plugin/Derivative/EntityActionsDeriver.php
-----------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------
 44 | WARNING | Unused variable $entity_type_id.
-----------------------------------------------------------------------------------


FILE: ...b/modules/contrib/entity/src/Plugin/Action/Derivative/DeleteActionDeriver.php
-----------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------
  7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong
    |       |     one is Drupal\Core\Entity\EntityTypeInterface.
 15 | ERROR | [ ] The text '@deprecated ' does not match the standard format:
    |       |     @deprecated in %deprecation-version% and is removed from
    |       |     %removal-version%. %extra-info%.
 15 | ERROR | [ ] Each @deprecated tag must have a @see tag immediately following
    |       |     it
-----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------


FILE: ...drupal-orgissue/web/modules/contrib/entity/src/Plugin/Action/DeleteAction.php
-----------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
-----------------------------------------------------------------------------------
 12 | ERROR | The text '@deprecated Use "entity:delete_action" instead.' does not
    |       | match the standard format: @deprecated in %deprecation-version% and
    |       | is removed from %removal-version%. %extra-info%.
 12 | ERROR | Each @deprecated tag must have a @see tag immediately following it
-----------------------------------------------------------------------------------


FILE: ...ite/drupal-orgissue/web/modules/contrib/entity/src/BundleEntityDuplicator.php
-----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------
 8 | ERROR | [x] Missing class doc comment
-----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------


FILE: ...upal-orgissue/web/modules/contrib/entity/src/EntityPermissionProviderBase.php
-----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------
 13 | ERROR | Missing short description in doc comment
-----------------------------------------------------------------------------------


FILE: ...al-orgissue/web/modules/contrib/entity/src/EntityAccessControlHandlerBase.php
-----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------
 11 | ERROR | Missing short description in doc comment
-----------------------------------------------------------------------------------


FILE: ...ssue/web/modules/contrib/entity/src/Controller/RevisionOverviewController.php
-----------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------
 13 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong
    |       |     one is Drupal\Core\Entity\RevisionLogInterface.
 40 | ERROR | [ ] Parameter $renderer is not described in comment
-----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------


FILE: ...rgissue/web/modules/contrib/entity/src/Controller/RevisionControllerTrait.php
-----------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
-----------------------------------------------------------------------------------
  7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong
    |       |     one is Drupal\Core\Entity\EntityInterface.
 17 | ERROR | [ ] Description for the @return value is missing
 24 | ERROR | [ ] Description for the @return value is missing
 94 | ERROR | [ ] Description for the @return value is missing
-----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------


FILE: ...issue/web/modules/contrib/entity/src/Controller/EntityDuplicateController.php
-----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------
 15 | ERROR | [x] Missing class doc comment
-----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------


FILE: ...emo-site/drupal-orgissue/web/modules/contrib/entity/src/EntityViewBuilder.php
-----------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
-----------------------------------------------------------------------------------
 12 | ERROR | The text '@deprecated in favor of
    |       | \Drupal\Core\Entity\EntityViewBuilder. Use that instead.' does not
    |       | match the standard format: @deprecated in %deprecation-version% and
    |       | is removed from %removal-version%. %extra-info%.
 12 | ERROR | Each @deprecated tag must have a @see tag immediately following it
-----------------------------------------------------------------------------------


FILE: .../Demo-site/drupal-orgissue/web/modules/contrib/entity/src/EntityViewsData.php
-----------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------
 153 | WARNING | Unused variable $type.
-----------------------------------------------------------------------------------


FILE: ...gissue/web/modules/contrib/entity/src/Routing/DeleteMultipleRouteProvider.php
-----------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
-----------------------------------------------------------------------------------
 13 | ERROR | The text '@deprecated Since Drupal 8.6.x the core
    |       | DefaultHtmlRouteProvider provides the route for any entity type with
    |       | a "delete-multiple-form" link template and a
    |       | "delete-multiple-confirm" form.' does not match the standard format:
    |       | @deprecated in %deprecation-version% and is removed from
    |       | %removal-version%. %extra-info%.
 13 | ERROR | Each @deprecated tag must have a @see tag immediately following it
-----------------------------------------------------------------------------------


FILE: .../web/modules/contrib/entity/src/EventSubscriber/EntityDuplicateSubscriber.php
-----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------
 10 | ERROR | [x] Missing class doc comment
-----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------


FILE: ...drupal-orgissue/web/modules/contrib/entity/src/Event/EntityDuplicateEvent.php
-----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong
   |       |     one is Drupal\Component\EventDispatcher\Event.
-----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------


FILE: ...rgissue/web/modules/contrib/entity/src/BundlePlugin/BundlePluginInstaller.php
-----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------
 11 | ERROR | [x] Missing class doc comment
-----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------


FILE: ...-orgissue/web/modules/contrib/entity/src/BundlePlugin/BundlePluginHandler.php
-----------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------
  9 | ERROR | [x] Missing class doc comment
 56 | ERROR | [x] Use null coalesce operator instead of ternary operator.
-----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------

Time: 3.27 secs; Memory: 16MB

    Kindly check

    Thanks,
    Jake

  • Comment 3 months ago ā†’
    šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹

    Notice that this issue is titled Update formatting for phpcs coding standards. It is not supposed to fix all the PHP_CodeSniffer errors/warnings.

    The merge request is 7 commits behind and 3 commits ahead of the upstream repository, but there are conflicts with the upstream repository. It is better to start from scratch with another merge request.

  • Comment 3 months ago ā†’
    šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹
  • Comment 3 months ago ā†’
    šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹
  • Merge request !36Issue #3331201: Update formatting as per Drupal coding standards ā†’ (Open) created by apaderno
  • Comment 3 months ago ā†’
    šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹
  • Pipeline finished with Success
    3 months ago
    Total: 176s
    #253501
  • Pipeline finished with Failed
    3 months ago
    Total: 145s
    #255916
  • Pipeline finished with Success
    3 months ago
    #255928
  • Comment 3 months ago ā†’
    šŸ‡ŗšŸ‡øUnited States capysara

    capysara ā†’ changed the visibility of the branch 3331201-drupal-coding-standards to hidden.

  • Status changed to Needs review 3 months ago
  • Comment 3 months ago ā†’
    šŸ‡ŗšŸ‡øUnited States capysara

    Rerolled against latest version.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024