- Merge request !3183Issue #3330481: Fix PHPStan L2 error "PHPDoc tag @foo has invalid value (Bar)" β (Closed) created by spokje
The Needs Review Queue Bot β tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- First commit to issue fork.
- πΊπΈUnited States smustgrave
Only left 1 comment but applied to a few spots. If we are fixing the lines around @throws should they not be fully name spaced?
- π¦πΊAustralia mstrelan
Re #10 I think you're referring to
\InvalidArgumentException
and\UnexpectedValueException
, both of which are global. - πΊπΈUnited States smustgrave
Ah okay. Makes sense but would be in favor of full name spaced but not a hill I'll fight on.
- π¦πΊAustralia mstrelan
To clarify further, both \InvalidArgumentException and \UnexpectedValueException are already fully namespaced, as in they are native PHP exceptions that do not have a namespace.
-
longwave β
committed b62ead8d on 11.1.x
Issue #3330481 by spokje, quietone, mstrelan, smustgrave: Fix PHPStan L2...
-
longwave β
committed b62ead8d on 11.1.x
-
longwave β
committed 5a87e35f on 11.x
Issue #3330481 by spokje, quietone, mstrelan, smustgrave: Fix PHPStan L2...
-
longwave β
committed 5a87e35f on 11.x
- π¬π§United Kingdom longwave UK
Nice to see all these little docs fixes, PHPStan always making us get better.
Committed and pushed 5a87e35f8fa to 11.x and b62ead8de53 to 11.1.x. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.