Add phpstan/phpstan-phpunit as a dev dependency

Discussed this with @mondrake in Slack, our plan is to:

- Use 🐛 DrupalStandardsListenerTrait is broken Closed: won't fix to fix DrupalStandardsListenerTrait and all the @covers errors it detects once fixed.
- Then return to this issue and try to get phpstan/phpstan-phpunit added as a dev dependency.
- Since we then have coverage of @covers (Baduum tish, I'm here all week, try the veal...) through phpstan/phpstan-phpunit we can then deprecate/remove DrupalStandardsListenerTrait in (Yet Another) issue to be more ready for PHPUnit 10 that drops the usage of listeners.

So, for now, postponing this issue on 🐛 DrupalStandardsListenerTrait is broken Closed: won't fix .

Rebased and fixed more errors that show up in code committed recently.

Rebased and fixed more errors that show up in code committed recently.

The blocker is in.

rebase and upgraded to 1.3.11

Thanks. As much as I hate the idea, I think we should better split the issue: here just the added dependency with baselined/ignored errors, and in followups the error fixes and baseline cleanup. On that.

Done #59 in MR!3737

Rebasing to be able to retest and get rid of the (alarmingly increased) random JS test failures.

Right....

Random JS test failures galore!

Not wasting any more test-cycles on that, marking RTBC.

Committed 947fd48 and pushed to 10.1.x. Thanks!

@mondrake one follow-up to clean-up baseline should be enough?

Opened 📌 [META] Fix PHPStan baseline suppressions introduced with phpstan/phpstan-phpunit Fixed to get rid of the new suppressions in the PHPStan baseline.

I created a CR for this https://www.drupal.org/node/3351386 →

Automatically closed - issue fixed for 2 weeks with no activity.

mondrake → closed merge request !3095

mondrake → closed merge request !3737