DrupalStandardsListenerTrait is broken

The @covers in the [driver]DriverLegacyTest classes

  /**
   * @covers Drupal\Core\Database\Driver\pgsql\Install\Tasks
   */

should just be removed IMHO - they trigger deprecations at the class autoloading time that phpunit-bridge cannot capture, and in any case those are just stub classes, there's no purpose in @covering them. Doing that you can leave the stubbed classes alone.

I can already see people complaining if we remove the docblock. Maybe change to

  /**
   * Tests deprecation of Drupal\Core\Database\Driver\pgsql\Install\Tasks
   */

Thanks @mondrake, I was trying to find out what triggered the (newly found) deprecations.
Might have eventually ended up with the @covers triggering them, but you were way ahead of me :)

Did however arrived at not-deleting-the-docblock-completely around the same time as you.

For the database specific schema test issues, I think it should suffice adding the abstract class Drupal\Core\Database\Schema to the @covers of the abstract class DriverSpecificSchemaTestBase, like

  /**
   * Tests various schema changes' effect on the table's primary key.
   *
   * @param array $initial_primary_key
   *   The initial primary key of the test table.
   * @param array $renamed_primary_key
   *   The primary key of the test table after renaming the test field.
   *
   * @dataProvider providerTestSchemaCreateTablePrimaryKey
   *
   * @covers \Drupal\Core\Database\Schema::addField
   * @covers \Drupal\Core\Database\Schema::changeField
   * @covers \Drupal\Core\Database\Schema::dropField
   * @covers \Drupal\Core\Database\Schema::findPrimaryKeyColumns
   */

and only in case of the test method being overridden at the specific database concrete test class, then specify a @covers for the driver's schema class.

No idea about why the listener test itself throw a deprecation, tho...

... exactly what you did ... :)

I have my moments ;)

Thanks!

This mostly looks good to me and (unlike 📌 Add phpstan/phpstan-phpunit as a dev dependency Fixed ) is mostly only fixing fails that can be evaluated within the context of the diff.

I reviewed the MR and left a few questions, a nitpick, and a request for at least an inline comment if not tests for the bugfix.

Tagging "Needs followup" for the place where the test method names are a lie.

Added comments on the MR.

Filed 🐛 Remove DrupalStandardsListenerTrait - it's broken, does not prevent errors, blocks better tooling Fixed for an alternative approach.

Over in 🐛 Remove DrupalStandardsListenerTrait - it's broken, does not prevent errors, blocks better tooling Fixed we decided to not fix this but remove it. So now onto 📌 Add phpstan/phpstan-phpunit as a dev dependency Fixed as the better fix.