PHP 8: Deprecated function errors

I can confirm, it works as expected.

Hi! I faced the same issues on the PHP8.1

I would suggest adding a return type to each method as the overridden methods only return the types of the parent methods.

The last submitted patch, 4: facetapi_deprecated_functions-3324815-4.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

@Pavel_SPN: If I am not mistaken, return type declarations were introduced in PHP 7, but Drupal 7's requirements list PHP 5.3 as the minimum.

Hi Ronino,

"The minimum recommended PHP version for Drupal 7 was PHP 7.2.x until its official end-of-life at 30 Nov, 2020."

https://www.drupal.org/docs/7/system-requirements/php-requirements-for-d... → (1)%20The%20minimum%20recommended%20PHP,get%20full%20PHP%208%20support.

I guess no one is using PHP 5.х anymore

You might be right, but even though 5.x is not recommended anymore it's still supported and still the minimum requirement ;-)

https://git.drupalcode.org/project/drupal/blob/7.x/INSTALL.txt#L18

PHP 5.3.3 (at least, PHP 7.x or greater recommended) (https://www.php.net/).

Ok, then let the maintainer decide which option is more suitable :)

There is a newer issue on this, with the same fix https://www.drupal.org/project/facetapi/issues/3352819 🐛 PHP 8.1: deprecated function warnings due to missing return type Closed: duplicate

I'm RTBCing this one in #2, but not to fussed which patch gets committed. But probably this one as it's older.

Hiding #4 patch

Hi, can it be in the next release version?

Methinks the module needs a new maintainer?

Thank you very much @joelpittet! Would be great to see a new release soon, does anyone know someone... ;D

New tagged release to follow shortly

New release
https://www.drupal.org/project/facetapi/releases/7.x-1.10 →

Automatically closed - issue fixed for 2 weeks with no activity.