Rerolled #29 against the latest 7.103 version.
Adapted to work with 7.x-2.8
image_features_revert() took hours lately when deploying to the production server, deleting tons of image derivatives from S3 even though no image style had changed. This fixed it for me. This is great, thanks!
#2 works for me, thanks!
#2 works for me, thanks!
RickJ wrote:
I don't agree that this patch is necessary. The admin page in question already requires "View revisions" access, which is noted as a trusted permission. This permission in fact covers the "administer" case. Ordinary users should not be able to see other users' revisions for obvious security reasons.
In my opinion, viewing something should never cover administering something. The user module does it right, introducing two permissions to view users ("access user profiles") and administer them ("administer users"). Likewise this module should either use the existing "administer users" permission to restrict access to configuration (like the issue title implies) or introduce its own administer permission (like #2 does).
I guess no one is using PHP 5.х anymore
You might be right, but even though 5.x is not recommended anymore it's still supported and still the minimum requirement ;-)
https://git.drupalcode.org/project/drupal/blob/7.x/INSTALL.txt#L18
PHP 5.3.3 (at least, PHP 7.x or greater recommended) (https://www.php.net/).
@Pavel_SPN: If I am not mistaken, return type declarations were introduced in PHP 7, but Drupal 7's requirements list PHP 5.3 as the minimum.
I cannot confirm #473. For me #332 applies fine on both 7.77 and 7.78 (apart from some offsets).