- 🇩🇪Germany ronino
image_features_revert() took hours lately when deploying to the production server, deleting tons of image derivatives from S3 even though no image style had changed. This fixed it for me. This is great, thanks!
In image_features_revert() it does not appear that the comparison of effects introduced in
#2148453: Image styles do not revert properly →
can ever be equal. The effect loaded from code does not contain effect callbacks, presumably they were removed in
#2308801: Export less data for image effects (within image styles) →
whereas the effect callbacks are present when loading the style using image_style_load(). So style effect array is never equal between the two.
The consequence of this is that it appears image styles in code are always reverted and flushed regardless as to whether they have changed our not. Flushing all image styles can cause broken images on larger sites especially if you are using picture module and images with sizes, as there appears to be a core issue preventing image styles from being created simultaneously, probably similar to the issue described in #3172863: Random "Failed to create style directory" on high concurrency and fresh styles/ directory → for Drupal 8+.
image_features_revert()image_features_revert() notice the in code style effect contains no callbacks whereas the loaded style does.Based on the work done for
#2308801: Export less data for image effects (within image styles) →
the loaded image style could be passed through _image_features_style_sanitize() to make it comparable with the image style in code.
Needs review
2.11
Image Styles
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
image_features_revert() took hours lately when deploying to the production server, deleting tons of image derivatives from S3 even though no image style had changed. This fixed it for me. This is great, thanks!