Add an option to 'hide filter tips' on text fields

I thought I would have this problem, having just switched from allowed_formats to the new core feature. But for some reason filter tips are not showing for me on the form, just the discreet "About text formats" link. I assumed that allowed_formats was hiding them, but now I'm not so sure how they are hidden. There is just an empty div.

>
<div class="js-filter-guidelines js-form-wrapper form-wrapper filter-guidelines" data-drupal-selector="edit-field-summary-0-format-guidelines" id="edit-field-summary-0-format-guidelines" data-once="filter-guidelines">
</div>
</

+1000 to this

+1001 to this

As a workaround you can hide it with this CSS snippet:

/* Hide text format help text */
.page-content .filter-wrapper {
  display: none;
}

Created MR to add the Hide Help and Hide Guidelines widget settings to core in a similar way as they are in Allowed Formats module.
Also added basic test coverage.

It will require some extra work, but let's use this initial approach to gather feedback and get the ball rolling.

Thanks for picking this up!

So far seems good,

The new schema changes will require an update hook + tests
All the core text field config will have to be updated to include the new config

For the form I imagine it could go right under "Allowed text formats"

Thank you for your review @smustgrave!

I was waiting for approach validation before going farther.

Fixed the broken tests.

Regarding the form, the idea is to define the settings at widget level, like in allowed_formats module, not at field level. But this can be discussed if the field level approach is preferred.

Regarding the form, the idea is to define the settings at widget level, like in allowed_formats module, not at field level. But this can be discussed if the field level approach is preferred.

+1 for adding it on widget level, so its easier to make allowed_format contrib module obsolete.

As well as providing options on each entity form display it might be nice to have a global option that sets this once everywhere. The widget configuration should probably then have options to either use the site-wide default setting, or explicitly hide/show the help and guidelines.

@mstrelan was quicker :-) exactly what I wanted to add.

+1 for a parent global and child sub setting overriding the global setting. Users are used to this from other admin UI experience. We have it in URL alias pattern, in states like "published" (default and on each node) and many other corners.

MR seems good.

+1 for having a global setting, overrideable on widget level.

If we wanted a global switch should this be a permission (or pair of permissions) provided by filter.module?

Also, I've said this in other issues - checking a box to hide something feels the wrong way round, the checkbox should be checked if we are showing something.

+1 to "Display tooltips" per longwave's suggestion - my preference would be off by default.

+1 here as well for off by default. i almost always end up hiding these.

yep, +1 for hiding the long tips, would be nice to have a tooltip when hovering a (?)

+1 to off by default as @longwave suggested