- 🇺🇸United States smustgrave
MR looks good and fixes the issue but this was previously tagged for IS update in #14 which still needs to happen.
- 🇮🇳India athyamvidyasagar
Drop down issue is fixed for D10. Patch and screenshots are attached.
- 🇺🇸United States bnjmnm Ann Arbor, MI
Hi @akshaydalvi212, are you familiar with Drupal's Gitlab integration → ? The patch you provided replicates work that is already in this issue's Merge Request, so it doesn't provide any additional value and would not receive credit. The contrib process can be confusing, especially with patches and Merge Requests both being valid ways to provide code changes in an issue. If the docs don't clear things up, it's usually possible to get additional guidance in Drupal slack, particularly if they are targeted questions vs requests for general assistance.
_______________
Issue summary updated.
- Status changed to Needs review
almost 2 years ago 3:26pm 7 June 2023 - last update
almost 2 years ago Custom Commands Failed - Status changed to Needs work
almost 2 years ago 11:12am 8 June 2023 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
almost 2 years ago 12:02pm 8 June 2023 - 🇮🇳India sourabhjain
Hidding the #20 patch files as we have already the MR. It is creating confusion.
- Status changed to Needs work
almost 2 years ago 12:27pm 8 June 2023 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
almost 2 years ago 1:19pm 8 June 2023 - 🇺🇸United States bnjmnm Ann Arbor, MI
The bot switched this to needs work because patch #20 was not passing tests. However, there was already a test-passing merge request awaiting review, so I'm switching it back to that. Be sure to review the MR not any patches (thanks @sourabhjain for hiding those)
And no shade on Needs Review Queue Bot - you are a good and helpful bot.
- Status changed to Needs work
almost 2 years ago 1:35pm 8 June 2023 - 🇺🇸United States smustgrave
Can the MR be rebased for 11.x and backported
Thanks.
- 🇫🇷France nod_ Lille
(bot was testing against 10.1.x, not 10.0.x might be why it complained)
- First commit to issue fork.
- last update
almost 2 years ago 29,551 pass - @sagarchauhan opened merge request.
- Status changed to Needs review
almost 2 years ago 11:24am 23 June 2023 - Status changed to RTBC
almost 2 years ago 1:48pm 23 June 2023 -
bnjmnm →
committed 0f2e209b on 11.x authored by
sagarchauhan →
Issue #3321726 by akshaydalvi212, ameymudras, sagarchauhan, bnjmnm: If...
-
bnjmnm →
committed 0f2e209b on 11.x authored by
sagarchauhan →
- Status changed to Fixed
almost 2 years ago 2:32pm 23 June 2023 - 🇺🇸United States bnjmnm Ann Arbor, MI
Good simple fix there. Committed to 11.x. Thanks folks!
Automatically closed - issue fixed for 2 weeks with no activity.