- ๐ฎ๐ณIndia Sonal Gyanani
Sonal Gyanani โ made their first commit to this issueโs fork.
- Status changed to RTBC
over 1 year ago 12:17pm 11 August 2023 - ๐ฉ๐ชGermany Anybody Porta Westfalica
Changes are fine, but shouldn't be credited.
- ๐ฉ๐ฐDenmark ressa Copenhagen
@Anybody: Do you mean that none of the committers who improved the README.md should be credited?
As far as I can tell, all three made valuable contributions:
- @Nila Hyalij made the initial patch
- @Dheeraj Jhamtani kindly created a patch in Gitlab, for easier preview
- @Sonal Gyanani put the cherry on top, by adding configuration
Denying credit automatically, for a clear improvement, only because it is about a README file is not fair, in my opinion.
Please see #3367061-21: Categorize contributions that could be considered 'gaming the credit system' and propose solutions (policy, automation, etc) โ for a discussion about this. Or maybe I misunderstood your comment?
- ๐ฉ๐ชGermany Anybody Porta Westfalica
Thanks @ressa sorry maybe I was wrong, I though I had read this as example in a presentation what should not be credited ;) Not my decision.
- ๐ฉ๐ฐDenmark ressa Copenhagen
No problem @Anybody, I just wanted to make sure :)
But please do participate in the discussion in the issue I linked to. I think it is very important to get this misunderstanding that README updates should by definition be seen as gaming the credit system sorted out.
As i see it, it is important to discern between spamming the issue queues with useless PHPCS reports or README screenshots (probably to game the credit system) and actual improvements, such as the one in this issue, where reformatting was done, as well as editing of content.
- ๐บ๐ธUnited States greggles Denver, Colorado, USA
I believe several of the changes here were unnecessary. For example:
-* You will probably want to change the welcome email (Administration +- You will probably want to change the welcome email (Administration
In my experience, the * is a more common character to use as a bullet and switching to a - is not a useful improvement. It makes the patch look bigger but is not objectively better.
- ๐ฉ๐ฐDenmark ressa Copenhagen
@greggles: The README.md template โ is using dashes and not asterisks.
I think we should streamline the mark up in README's by following that template.
- ๐บ๐ธUnited States greggles Denver, Colorado, USA
Thanks for sharing that documentation! I'm not sure if that was an explicit choice or not, but I support the documented version. Looking at the history of that pgae I can see it was changed from bullet to dash in 2022, but the revision message is not visible to explain why or how much discussion occurred. Regardless, I'll use - for now.
- ๐ฉ๐ฐDenmark ressa Copenhagen
Great! It's like indentation, should it be four spaces, or two? How about tabs? At some point it just makes sense to make a decision, and stick to that -- be it two or four spaces, or dashes or asterisks. In this case based mostly on Gitlab style.
- Status changed to Needs work
about 1 year ago 10:38am 5 October 2023 - ๐ฉ๐ชGermany Grevil
We should also use this issue to remove outdated information inside the README.
- If a user enters an invalid email or password they will see a message:
"Unrecognized username or password. Forgot your password?"
That message is confusing because it mentions username when all other
language on the page mentions entering their email. This can be easily
overridden in your settings.php file with an entry like this:```
$settings['locale_custom_strings_en'][''] = [
'Unrecognized username or password. Forgot your password?
' => 'Unrecognized e-mail address or
password. Forgot your password?',
];
```This is outdated. The validation message is already correct without any changes (implemented through "email_registration_user_login_validate()"). Let's remove it.
- First commit to issue fork.
- last update
about 1 year ago 3 pass, 2 fail - Status changed to Needs review
about 1 year ago 12:58pm 6 October 2023 - Assigned to Grevil
- Assigned to Anybody
- ๐ฉ๐ชGermany Grevil
Just a few tiny additions, everything LGTM! Final changes review by @Anybody.
- Status changed to RTBC
about 1 year ago 3:16pm 9 October 2023 - Status changed to Fixed
about 1 year ago 3:16pm 9 October 2023 -
Anybody โ
committed 79f73eae on 8.x-1.x authored by
Dheeraj Jhamtani โ
Issue #3320640 by Nila Hyalij, Grevil, Anybody: Replace README.txt with...
-
Anybody โ
committed 79f73eae on 8.x-1.x authored by
Dheeraj Jhamtani โ
- Status changed to Needs work
about 1 year ago 7:18am 10 October 2023 - ๐ฉ๐ชGermany Grevil
Adjusting the README, based on comments by @LRWebks.
-
Grevil โ
committed 483a921a on 8.x-1.x
Further README adjustments related to Issue #3320640
-
Grevil โ
committed 483a921a on 8.x-1.x
- Issue was unassigned.
- Status changed to Fixed
about 1 year ago 7:22am 10 October 2023 - ๐ฉ๐ชGermany lrwebks Porta Westfalica
Grevil โ credited LRWebks โ .
-
Anybody โ
committed 4ede14ba on 8.x-1.x
Further README adjustments related to Issue #3320640
-
Anybody โ
committed 4ede14ba on 8.x-1.x
Automatically closed - issue fixed for 2 weeks with no activity.