- π©πͺGermany Anybody Porta Westfalica
Thanks @_nod! Looking at π Include Cache-Control header on 301 redirects. RTBC and thinking about explicit rules per mime type I think we should keep this as-is and let the redirect do its own thing in the other issue.
Otherwise, this will end up for us in having to update the mime types for every new image type etc. - I don't thing that's a good thing.
For such an example see https://www.supertechcrew.com/htaccess-rules-security-cache-redirect/ > "Caching rules"Do you agree?
Setting this back to "Needs review" for that reason. I still think the changes are good.
- Status changed to RTBC
almost 2 years ago 5:44pm 20 February 2023 - πΊπΈUnited States smustgrave
Seems fine to me. lets see what the committers say.
- Status changed to Needs work
almost 2 years ago 1:30am 19 March 2023 - π¬π§United Kingdom alexpott πͺπΊπ
Changes to .htaccess need a release note and a CR because they can require users to make updates since this can be hand edited. See π Duplicate X-Content-Type-Options headers both with the value nosniff Fixed as an example of the things needed.
- Status changed to Needs review
over 1 year ago 3:37pm 20 March 2023 - π©πͺGermany Grevil
I created a CR draft here: https://www.drupal.org/node/3349094 β and a release note snippet got added in the issue summary.
Please correct me if either the snippet, or the CR draft is incorrect, as I don't have enough insights.
- Status changed to RTBC
over 1 year ago 5:00pm 20 March 2023 - πΊπΈUnited States smustgrave
Took a look at the change record and change makes sense. Examples of why the change happened should be useful to others.
- Status changed to Fixed
over 1 year ago 11:59am 21 March 2023 -
alexpott β
committed 67357a32 on 10.1.x
Issue #3311406 by Anybody, Grevil, nod_: .htaccess ExpiresDefault (2W)...
-
alexpott β
committed 67357a32 on 10.1.x
- π¬π§United Kingdom alexpott πͺπΊπ
Discussed with @catch we agreed that js and image styles all have cache busting logic. This will change how long logos and favicons for. Even today if you change these it would be recommended to use a different file name because they are already cached for 2 weeks.
- π©πͺGermany Anybody Porta Westfalica
Funny question, I know. But should we backport this to Drupal 7? Also 14d there...
- π¬π§United Kingdom longwave UK
@Anybody I would open a separate issue to discuss - D7 is somewhat more conservative around changes and the considerations there might be different. If someone was already affected by this on D7 they likely would have already made this change to their site; nobody should be building new sites on D7.
- π³πΏNew Zealand quietone
Tweaked the release note snippet and changing tags.
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
over 1 year ago 12:01pm 8 September 2023