Add outline to buttons with active state.

Sounds like a WCAG 1.4.1 issue.

Seems simple enough but I know better than to RTBC a CSS patch :)

Passes manual testing.

Before patch:

After patch:

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Re-rolled patch #3, for 10.1.x. Also I have removed !important and improved the nesting of element. please review.

Active state with #2977ff color outline.

After patch #10:

I think this needs to be RTBC'd by one of these folks:

Accessibility
- Rain Breaw Michaels 'rainbreaw' https://www.drupal.org/u/rainbreaw
- Mike Gifford 'mgifford' https://www.drupal.org/u/mgifford
- Andrew Macpherson 'andrewmacpherson' https://www.drupal.org/u/andrewmacpherson
- (provisional) Ben Mullins 'bnjmnm' https://www.drupal.org/u/bnjmnm

Patch #10 looks much better!

#12 Agreed! But that made me realize something … this is currently being tested in a single theme (Claro).

We also need to verify that this works correctly in other themes. At minimum also Olivero (e.g. on the comment form). Tagging for that.

It works in Olivero and Stark. Seems very RTBC-able but will await accessibility review.

Not on the accessibility team but tested and this failures color contrast.

@smustgrave this issue adds an outline matching the existing color scheme, so I think changing the color scheme should be a separate issue?

Yeah, #3283803-12: [upstream] CKE5 toggleable toolbar items not enough contrast → explains the current active state behaviour which is handled upstream in CKEditor.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

So what's the accessibility review needed for? If it fails and we accept it fails do they still need to check?

That failure is valid too meant to add in my comment. Didn't apply anymore.

I’m not sure, since it’s sticking to the existing color scheme, and changing that is definitely out of scope.

Just make sure it meets color contrast requirements. Removing "Needs Accessibilty Review" unless this is more complicated.

Highlighted the active buttons on CKEditor 5 .

Patch in merge request: MR !6984

After patch:

WCAG test shows pass for Graphical Objects and User Interface Components:

Change makes sense.

nod_ → closed merge request !6984

Committed 229f626 and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.