Replace the test class protected $modules deprecation error with a phpstan-drupal rule

It's done upstream https://github.com/mglaman/phpstan-drupal/issues/463, we need a point relaease to pin to and then we can get rid of the check.

mglaman/phpstan-drupal just released 1.2.1. Once that's updated in core, this issue will be feasible.

Added 📌 Update mglaman/phpstan-drupal to 1.21 for 3301205 Active

📌 Update mglaman/phpstan-drupal to 1.21 for 3301205 Active was committed. This is no longer postponed.

MR 5310 is OK. It bumps the minimum phpstan-drupal release to the one that performs the check, hence the hash in composer.lock needs to change. Tests for the feature removed from the listener and added to phpstan-drupal are performed upsteram, so this is just a net removal.

Thanks

Damn @mondrake, that's very quick and _exactly_ the reasoning I was about to put into the IS! :)

Looking at \Drupal\Tests\Listeners\DrupalListener a bit closer, I feel we can replace (and then deprecate \Drupal\Tests\Listeners\DrupalComponentTestListenerTrait) with another phpstan-drupal rule. I feel core is doing work in that trait that is now coverable by PHPStan.

After that is done, I think DrupalListener is basically an "empty" wrapper around \Symfony\Bridge\PhpUnit\SymfonyTestsListener and might be up for removal?
But the latter is me treading into waters that are above my pay grade.

I'll open up an issue for

DrupalComponentTestListenerTrait

in here (postponed) and one in the mglaman/phpstan-drupal/ queue shortly.

#23 cool.

The follow-up is great.

General point with listeners: they are deprecated and simply no longer there in PHPUnit 10.
So my approach is: any steps taken to thoroughly remove them is good; any step in the direction of refactoring them but keep them is a waste of time.

Thanks for the confirmation @mondrake, I try to keep up with all the PHPUnit/Symfony-bridge work you're doing, but it's hard to keep up with your good work.

Thanks... honestly I'm not even sure where Symfony's phpunit-bridge is going, see e.g. https://github.com/sebastianbergmann/phpunit/issues/5532.

So, ATM we're pretty much sitting on the river's bank...

+1 to removing the listeners as it is a step towards PHPUnit 10 even if that seems to be getting no closer every time I look at it.

Committed and pushed to 11.x and 10.2.x, thanks!

Spokje → closed merge request !5310

Automatically closed - issue fixed for 2 weeks with no activity.