Automated Drupal 10 compatibility fixes

Here is an updated patch that applies to the latest 8.x-3.x-dev branch

Patch #2 is not getting applied for me. I have checked with Patch #9, it is working fine without error for Drupal 9 (9.5.7) and Drupal 10 (10.0.3).

RTBC +1

Patch #9 fails with Drupal 10.0.9

Updated patch for latest version of branch 8.x-3.x-dev.

Can we get the latest patch merged?!? Need this in d10 asap.

Also need this to get merged to D10 compatibility.

As a workaround, you can apply this patch but you will have to make sure to add this to your composer.json:

        "preferred-install": {
            "drupal/views_fieldsets": "source"
        }

However... If you use Pantheon, or another service which runs the composer install command for you, the --prefer-dist flag will override that workaround and you won't be able to patch the .info.yml file because Drupal adds packaging information to that file ( https://www.drupal.org/project/drupalorg/issues/3066468 📌 Packaging info from .info.yml often creates conflicts when patching (ddo) Active ).

So... Would be really nice to get this merged!

@marcaddeo, I haven't tested this myself, but this composer plugin might help https://packagist.org/packages/orakili/composer-drupal-info-file-patch-h...

That being said, it definitely shouldn't be used as an excuse to delay this issue being merged and released.

It's a little cumbersome to work with issue forks at the moment.

@codebymikey: THANK YOU! That's super helpful.

I was just 85% through re-hosting a fork of this repo on GitHub with the patches applied to get around this, but your solution is easier haha.

Another temporal option is the plugin https://packagist.org/packages/mglaman/composer-drupal-lenient

Used Lenient as mentioned in #19... looks like the best solution for patching D9 modules to D10.

Although patch #14 didn't apply to 8.x-3.4 on core 10.0.9.

@chucksimply: The patch applies cleanly. The problem is Drupal adds packaging info to the info file when downloading the dist version.

Checkout #16 and #17 for more info and solutions.

Hi @chucksimply,

The patch requires the dev version.

Under composer require:

    "require": {
         "drupal/views_fieldsets": "3.x-dev@dev",

And under drupal-lenient:

        "drupal-lenient": {
            "allowed-list": [
                "drupal/pdf",
                "drupal/views_fieldsets"
            ]
        }

Note: the last one if you use Lenient.

Okay, switched to dev and worked fine. Thanks

Have also just given this a test. The patch from #14 applies and works correctly with 10.0.9 for both the dev and dist versions.

Please can this be rolled in to a release as we are awaiting this for a D10 project.

Thanks.

+1 RTBC

+1 RTBC

thidd → made their first commit to this issue’s fork.

Compose wouldn't apply #14, so regenerated the same patch (no changes).

Oops patch only appiles for dev version due to different info.yml, attached patch for 3.4 module version for composer runs.

#29 works.

smustgrave → closed merge request !2

smustgrave → reopened merge request !2

Okay had some issues because 8.x-3.4 tag was ahead of the 8.x-3.x dev branch.

Merged into 4.0.x but will ask if some testing could be done and posted on https://www.drupal.org/project/views_fieldsets/issues/3384586#comment-15... 🌱 Meta 4.0.0 release Fixed before a release is made

Automatically closed - issue fixed for 2 weeks with no activity.