Packaging info from .info.yml often creates conflicts when patching (ddo)

Created on 8 July 2019, almost 5 years ago
Updated 12 April 2024, 2 months ago

Original issue on Drupal core project πŸ› Packaging info from .info.yml often creates conflicts when patching Active

Problem/Motivation

Disclaimer: Not sure that is the right project to post this.

  1. Add a module as dist (using a stable, beta, alpha version) in your composer.json.
  2. Create a patch that fixes the .info.yml file.
  3. Add the patch in composer.json and update.

In most of the cases the paching will fail because the content of the dist .info.yml contains also the packager script lines. The patch is build every time using the source, where those lines doesn't exist.

Proposed resolution

The .info.yml file is part of the codebase, it should not be altered by any script.

Long term solution

Move these package info in their own file that should be added by the the packager script, as LICENSE.txt is added.

Quick fix

Before the line # Information added by Drupal.org packaging script on ... add enough empty lines, so that the changed hunk doesn't interfere. Will still be a problem with the .info.yml files of sub-modules being deleted.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

N/A

πŸ“Œ Task
Status

Active

Version

3.0

Component

Code

Created by

πŸ‡·πŸ‡΄Romania claudiu.cristea Arad πŸ‡·πŸ‡΄

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.69.0 2024