πŸ‡ΊπŸ‡ΈUnited States @marcaddeo

Rhode Island
Account created on 29 September 2015, about 9 years ago
#

Recent comments

πŸ‡ΊπŸ‡ΈUnited States marcaddeo Rhode Island
πŸ‡ΊπŸ‡ΈUnited States marcaddeo Rhode Island

Added a MR that addresses the issue with Chinese.

πŸ‡ΊπŸ‡ΈUnited States marcaddeo Rhode Island

marcaddeo β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States marcaddeo Rhode Island

@chucksimply: The patch applies cleanly. The problem is Drupal adds packaging info to the info file when downloading the dist version.

Checkout #16 and #17 for more info and solutions.

πŸ‡ΊπŸ‡ΈUnited States marcaddeo Rhode Island

@codebymikey: THANK YOU! That's super helpful.

I was just 85% through re-hosting a fork of this repo on GitHub with the patches applied to get around this, but your solution is easier haha.

πŸ‡ΊπŸ‡ΈUnited States marcaddeo Rhode Island

Also need this to get merged to D10 compatibility.

As a workaround, you can apply this patch but you will have to make sure to add this to your composer.json:

        "preferred-install": {
            "drupal/views_fieldsets": "source"
        }

However... If you use Pantheon, or another service which runs the composer install command for you, the --prefer-dist flag will override that workaround and you won't be able to patch the .info.yml file because Drupal adds packaging information to that file ( https://www.drupal.org/project/drupalorg/issues/3066468 πŸ“Œ Packaging info from .info.yml often creates conflicts when patching (ddo) Active ).

So... Would be really nice to get this merged!

Production build 0.71.5 2024