Am seeing this issue with focal_point 2.0.2
Putting the suggestion from #2 in to a custom module resolves the issue for me as a workaround until fixed properly.
e.g.
function MODULE_NAME_form_media_library_add_form_dropzonejs_alter(array &$form, \Drupal\Core\Form\FormStateInterface $form_state) {
focal_point_form_media_library_add_form_upload_alter($form, $form_state);
}
I've had a look at your PR and removing that file makes perfect sense. I have tested removing the file and can see no issues with it removed.
Can I suggest this ticket be closed and marked as a duplicate of https://www.drupal.org/project/views_fieldsets/issues/3299447 📌 Automated Drupal 10 compatibility fixes Fixed as discussion and testing is going on on that ticket. Thanks.
Have also just given this a test. The patch from #14 applies and works correctly with 10.0.9 for both the dev and dist versions.
Please can this be rolled in to a release as we are awaiting this for a D10 project.
Thanks.
Brilliant - thanks for that.
I have just retested with 4.0.0-beta1 and as far as I can see it is all working as expected.
I have just manually tested the patch from #2 and everything is working as expected. Please can this patch be applied and a new version released?
It should be noted however that the code to fix the deprecated functions requires "^9.3 || ^10" and so applying that patch breaks compatibility with
I have just tested this with D10. The patch as per #6 does not work as there is code that is deprecated in D10 that needs updating.
I then tested the patch from https://www.drupal.org/project/field_group_background_image/issues/3297197 📌 Automated Drupal 10 compatibility fixes Fixed as suggested in #3 which replaces the deprecated code and that works as expected.
It should be noted however that the code to fix the deprecated functions requires "^9.3 || ^10" and so applying that patch breaks compatibility with <D9.3 and D8. Therefore it is probably better to move the module to a new major version when this patch from https://www.drupal.org/project/field_group_background_image/issues/3297197 📌 Automated Drupal 10 compatibility fixes Fixed is applied.
I've had a look at this compared to what you get out of core now and core looks to do everything this module does, with added functionality, therefore it looks to me like this module is now redundant.
So I agree with you in that it should be documented on the module page as to whether this module is still relevant from D9 onwards, and if the maintainers think it is still relevant some explanation added as to why you would use it over what is in D9 core.