- First commit to issue fork.
- 🇬🇧United Kingdom nickrhymes
I have just manually tested the patch from #2 and everything is working as expected. Please can this patch be applied and a new version released?
It should be noted however that the code to fix the deprecated functions requires "^9.3 || ^10" and so applying that patch breaks compatibility with
- Status changed to RTBC
over 1 year ago 3:03pm 16 June 2023 - pere orga Catalonia
Thanks @nickrhymes! I just created https://www.drupal.org/project/field_group_background_image/releases/4.x... →
- pere orga Catalonia
4.0.0-beta1 created too, which is now visible in the project page.
- 🇬🇧United Kingdom nickrhymes
Brilliant - thanks for that.
I have just retested with 4.0.0-beta1 and as far as I can see it is all working as expected.
- Status changed to Fixed
over 1 year ago 1:59pm 21 June 2023 - 🇪🇸Spain fjgarlin
@pere-orga - in an effort to attribute the right people the right kind of credit, would you mind editing the credit attribution of this "Fixed" issue.
It seems that one of the users that was attributed credit didn't really do much in order to move the issue forwards, and the user that actually helped with the testing wasn't credited.
If in doubt about who to credit, you can always reach out in the community slack channel #contribution-recognition-feedback where these topics are often discussed.
Thanks!
- pere orga Catalonia
Sorry, should be fixed now. Thank you for your message!
I thought I had properly attributed credit in the commit message, and I was not aware that these checkboxes did anything.
- 🇪🇸Spain fjgarlin
No worries at all and thanks for editing!!
The commit message is a convention, but we take the actual credits from the checkboxes as we started to have non-code contributions within the community.
Automatically closed - issue fixed for 2 weeks with no activity.