Automated Drupal 10 compatibility fixes

Vasyl Vasylkiv → made their first commit to this issue’s fork.

Hi there! I'm facing issues with this fork since the composer.json file in the root module folder has these requirements:

<?PHP
"require": {
"php": ">=7.1",
"drupal/message": "^1.0",
"drupal/message_notify": "^1.0",
"drupal/core": "^8.8.0 || ^9.0"
},
?>

Could we update these items as well? My suggestion is to use PHP 8.1 and core ^9.4 || ^10.
Another option is to use >=7.4 || >=8.1 and core ^9 || ^10.

Hi there,

I am making available a patch based at 3.0.0-beta2 version.

In this patch I worked in some issues that bot didn't fix, see more below:

• jQuery.once: [#3158256]
• Updating .info files
• Update PHP and Drupal Version at Composer

I have tried this MR !66 in drupal 10.1.4 and its working perfectly fine but when trying to apply #8 patch getting this error

error: modules/private_message_notify/private_message_notify.info.yml: No such file or directory

Still preparing for Drupal 10 and patch in #8 applies with no problems.

Drupal core 9.5.10
Private Message 3.0.0-beta2
PHP 8.1.0

Hey @kalash-j the issue is that MR !66 is based on branch 8.x-2.x and patch #8 is based on the latest branch 3.0.x this is why the patch is failing, as you can see here https://git.drupalcode.org/project/private_message/-/blob/3.0.x/modules/... the submodule only exists on branch 3.0.x

You can check what branch the MR is using going here: https://git.drupalcode.org/project/private_message/-/merge_requests/66 and checking the target branch that it will be merged to, this information is available at the header right under the title of the issue.

Vasyl Vasylkiv requested to merge issue/private_message-3297888:3297888-automated-drupal-10 into 8.x-2.x 6 months ago

I thing there is a bit of confusion on this issue, the issue is marked as version 8.x-2.x, so all MR / patches should be based on that and should apply to 8.x-2.x branch. The MR https://git.drupalcode.org/project/private_message/-/merge_requests/66 is doing exactly that and it is indeed applying correctly. So we need to test the MR #66, then it will be up to the maintainer if they are gonna support the D10 for the 8.x-2.x branch.

The #8 patch from @viniciusrp is based off 3.0.x branch , so that patch is not applying, furthermore the 3.0.x branch is already supporting D10 as you can see from this commit https://git.drupalcode.org/project/private_message/-/commit/f89100019c20... , so the patch is not needed.

@nkoporec In that case, given the approaching EOL for Drupal 9, may I suggest there needs to be a new 3.0 release. The current one (beta2) is listed as "core_version_requirement: ^8.8 || ^9" and not everybody will/can use the dev.

https://www.drupal.org/project/private_message/releases/3.0.0 → has a tagged release that now supports Drupal 10.

Hi @heddn,
I've just opened the issue queue going to finally deal with the D10 realease and found that you already did that.
Thank you very much!

Sorry everyone that it took so long.
I suppose this one should be closed too

Automatically closed - issue fixed for 2 weeks with no activity.