Refactor Claro's file stylesheet

Added variables on component level. please review

Nesting looks good

But not sure if these spaces are needed

  --file-font-size: var(--font-size-s);

  min-block-size: calc(var(--file-space-m) + var(--file-offset));

  --file-size-color: var(--color-gray-800);

  color: var(--file-size-color);

But not sure if these spaces are needed

Even without spaces in pcss.css file, compiled CSS file have the space after declared variable. I think we need these space to differentiate between variables and properties.

If that's the case then this should be fine.

// Ignore this patch
I am new to env. Checking the patch works or not.

Addressed #44, attached patch and interdiff with #40 for same. please review

#44 seems to be addressed.

Seems random failure.

The last submitted patch, 52: 3293398-52.patch, failed testing. View results →

I reviewed this Patch and doesn't seem to have any issue. The patch LGTM. But the error message that is mentioned typically appears in PHPUnit tests when an assertion is made that an object or array should be empty, but it is not.

Drupal\Tests\user\Kernel\Migrate\MigrateUserStubTest
fail: [Other] Line 0 of sites/default/files/simpletest/phpunit-1178.xml:
PHPUnit Test failed to complete; Error: PHPUnit 9.5.28 by Sebastian Bergmann and contributors.

Testing Drupal\Tests\user\Kernel\Migrate\MigrateUserStubTest
F                                                                   1 / 1 (100%)

Time: 00:01.502, Memory: 4.00 MB

There was 1 failure:

1) Drupal\Tests\user\Kernel\Migrate\MigrateUserStubTest::testStub
Failed asserting that an object is empty.

/var/www/html/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:122
/var/www/html/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:55
/var/www/html/core/modules/migrate_drupal/src/Tests/StubTestTrait.php:22
/var/www/html/core/modules/user/tests/src/Kernel/Migrate/MigrateUserStubTest.php:35
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

FAILURES!
Tests: 1, Assertions: 8, Failures: 1.

It is not related to the CSS code itself.

So i guess we can move it to RTBC.

Thanks

Random failure

The last submitted patch, 52: 3293398-52.patch, failed testing. View results →

Ticket isn’t having luck with random failures

The last submitted patch, 52: 3293398-52.patch, failed testing. View results →

Tested the patch #52 which is is showing fail testing,
It is applying cleanly.I think failure is not related to patch

Patch #52, still applies on 11.x. Restoring the status

Committed 9cd4453 and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.

This is a minor only change, removing tag for the followup.