The [0] hatch in misc/vertical-tabs.js causes issues if there are multiple forms with vertical tabs

Re-roll for 10.0.x

I also have a project with the drupal/shortcode module and the patch from #5 fixes the problem!

A quick solution to remove the error for now on drupal 10.1.0

Patch #8 from @eugene.brit works perfectly on D10.

Because of #11

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

I am working on this.

Fixed linting errors

Can we add a test case to cover this bug.

Hello,

Thank you for the contribution.

I've encountered a similar issue with the nd_visualshortcodes module.

Applying the patch from the merge request using Composer:

"patches": {
    "drupal/core": {
        "[3291764] The [0] hatch in misc/vertical-tabs.js causes issues if there are multiple forms with vertical tabs.": "https://git.drupalcode.org/project/drupal/-/merge_requests/2420.patch"
    }
}

It worked for me. Thank you very much!

Tested on Drupal 9.5.11

Thanks @kostyashupenko : patch #15 works in Drupal 10.2.2

The patch solution is a bit more complex than it needs to be. Looping through the results called by get() should be sufficient as it will simply not loop through anything if there are no results

      .siblings(':hidden.vertical-tabs__active-tab')[0].value =
        this.details.attr('id');

can be replaced with
.siblings(':hidden.vertical-tabs__active-tab').get().forEach((hidden) => hidden.value = this.details.attr('id');)

The issue summary currently suggests a solution that 1) would not work as jQuery does not have a .value property 2) suggests reverting back to jquery value settings, which our linter would not allow.

Update the suggestion to something that reflects what is actually happening.

As a committer / FEFM I'm fine with no tests on this as long as the scope of changes is just ensuring that value is not called on a result that might be empty.

Gauravvvv → changed the visibility of the branch 3291764-the-0-hatch to hidden.

Adding back the issue summary tag from #20.

Can it be updated to include the solution and why it's needed. Currently it's showing the diff of the MR essentially

Thanks!

Updated the Proposed resolution section explaining the solution.

Thank you @Utkarsh_33 for providing the additional detail.

Believe all feedback has been addressed

Committed and pushed 8c9ff22228 to 11.x and 035142460f to 11.0.x and 10691987c8 to 10.4.x and c55ad7b289 to 10.3.x. Thanks!

nod_ → closed merge request !8366

Automatically closed - issue fixed for 2 weeks with no activity.