- πΊπΈUnited States smustgrave
Ran the test locally for #44 and it fails with
Failed asserting that exception message 'Unable to parse at line 1 (near " do not:").' contains 'The file "vfs://drupal/modules/example/example.yml" does not contain valid YAML'.
Tried breaking an existing service but could not but the test shows the issue just fine I believe.
Looks good!
- Status changed to Needs review
almost 2 years ago 4:00pm 6 February 2023 - π¬π§United Kingdom catch
Is this a case where we should be using assertions instead of exceptions? See for example #2454649: Cache Optimization and hardening -- [PP-1] Use assert() instead of exceptions in Cache::merge(Tags|Contexts) β . Since there are other similar exceptions in the same file, maybe a follow-up?
- Status changed to RTBC
almost 2 years ago 8:36pm 6 February 2023 - πΊπΈUnited States smustgrave
Opened π YamlFileLoader use assertions instead of exceptions Closed: works as designed
- Status changed to Fixed
almost 2 years ago 9:33pm 6 February 2023 Automatically closed - issue fixed for 2 weeks with no activity.