- ๐ฉ๐ฐDenmark ressa Copenhagen
Yes, I also prefer to not show redundant and distracting elements, and maximize the working area, when I am creating content, so this would be a nice feature.
- Open on Drupal.org โCore: 9.5.x + Environment: PHP 7.4 & MySQL 8last update
29 days ago Waiting for branch to pass - Status changed to Needs review
29 days ago 8:15pm 29 May 2024 - ๐ฉ๐ฐDenmark ressa Copenhagen
Here's a rough sketch. For some reason, the boolean value is saved as
1
or0
, and nottrue
orfalse
... so, if for some reason it is saved as1
on some systems andtrue
on others, used this:if ($toolbar_top === TRUE || $toolbar_top === 1)
- ๐ฎ๐ณIndia dev16.addweb
silvi.addweb โ made their first commit to this issueโs fork.
- Open on Drupal.org โCore: 9.5.x + Environment: PHP 7.4 & MySQL 8last update
29 days ago Waiting for branch to pass - ๐ฎ๐ณIndia dev16.addweb
I have added toolbar top to schema, Now boolean value is saved as true or false. please review.
- Open on Drupal.org โCore: 9.5.x + Environment: PHP 7.4 & MySQL 8last update
28 days ago Waiting for branch to pass - ๐ฉ๐ฐDenmark ressa Copenhagen
Thank you very much for a fast reply, and fixing this problem for me @silvi.addweb. It now works perfectly, and the values used are
true
orfalse
as desired. I have updated the check to just useif ($toolbar_top === TRUE)
. If you have time, feel free to review the patch, and see if it works as expected, and the rest of the code looks all right. Thanks! - ๐ฌ๐งUnited Kingdom bmango
I have applied the patch for this and it works as expected. Many thanks!
- ๐ฉ๐ฐDenmark ressa Copenhagen
Thanks for reviewing @bmango! Feel free to change the status to RTBC.
- ๐ฎ๐ณIndia Kanchan Bhogade
Tested MR 76 on Drupal 10
The MR is applied cleanly...Adding screenshot
RTBC+1
- Status changed to RTBC
18 days ago 6:44am 10 June 2024