- Issue created by @ressa
- First commit to issue fork.
- π¬π§United Kingdom aaron.ferris
aaron.ferris β made their first commit to this issueβs fork.
- π¬π§United Kingdom aaron.ferris
Made an initial MR for this - we could always add an update hook to make sure this setting exists, ive coded defensively for it.
- Status changed to RTBC
7 months ago 2:10pm 14 September 2024 - π©π°Denmark ressa Copenhagen
This is awesome @aaron.ferris, thanks!
It works perfectly, and bumping "Hover Intent Timeout (ms)" up to 500 ms or even 750 ms allows for non-precise mousing, without having to start all over with a multi-level traversal, due to slipping out of the menus accidentally. I'll set to RTBC, and if more code is on the way, it can always be reverted to "Needs work".
PS. Setting timeout to 0 ms and speed-running Drupal menus, traversing to the deepest level of all menus could be a new sports discipline :-)
- π¬π§United Kingdom aaron.ferris
No problem, glad itβs working well for you.
- First commit to issue fork.
- πΊπΈUnited States redeight
I can confirm that this does indeed work well. In addition, by moving the hoverintent to a drupal behavior instead of $(document).ready it fixes another issue I've been seeing on some of my sites where hoverintent failed to work at all.
- π«π·France dydave
Thanks a lot everyone for the great work on this issue, it's greatly appreciated!
I've rebased/fixed a few conflicts that were blocking MR!99 and it should be good now.
I haven't tested the feature yet, but after a very quick review of the MR, it looks good overall, great job! π
I think there are a few more changes I'd like to add to the MR, in particular, I think the whole
hoverintent
feature should probably be moved out from theadmin_toolbar_tools
module to theadmin_toolbar
.
This feature "should" work without theadmin_toolbar_tools
module, so the config variablehoverintent_functionality
should be move out toadmin_toolbar
, impacting the schema, the settings forms and probably the install files of the module (to update module's configuration on all sites).
I'll then add a formstate
to the addedhover_intent_timeout
config field to hide or show if the functionality is enabled or disabled.Lastly, we'll mostly likely need to add Functional tests for this:
https://git.drupalcode.org/project/admin_toolbar/-/blob/3.x/tests/src/Fu...More work is needed on this, so I'm setting this to Needs work and will circle back on this in the next few days: I'm going to need a few hours to get this properly fixed.
Bringing this one back up to the top of the list.
The good news is that the changes at this point seem pretty straight forward, therefore there are great chances this feature could be merged in the coming days/weeks.At which point the MR will be set back to Needs review and we will need you help testing and reviewing again.
Thanks again! - π«π·France dydave
We'll see, but I'll most likely split this into a separate ticket to get the
hoverintent_functionality
moved out fromadmin_toolbar_tools
toadmin_toolbar
and come back to this issue right after to add thestate
on the field added by the MR.More coming in the next few days.
Cheers!