RedEight β created an issue.
Is there something else that was supposed to populate that call to render with the $results it was expecting? Did Drupal change something so it no longer does that?
So, I believe the issue is that StylePluginBase->render() doesn't take any parameters, but StyledGoogleMapsStyle->render is defined as public function render($results = [])
and nothing passes anything to that $results. Adding $results = $this->view->result;
as the first line of StyledGoogleMapsStyle->render suddenly fixes the issue. Which makes sense. The render function has access to the result directly from itself, no reason to pass in another array entirely.
As hudri said, the patch fixes an issue we're having with using these options on our sites.
I can definitely confirm all of this.
My apologies. Running the update after installing 4.1 was what I was missing. It's now showing bigint. Thanks!
The date and enddate are stored as INT after installation, but duration is stored as bigint. Is there any reason we aren't storing the start and end as bigint?
I've had this issue cause an error on two of my sites with thousands of media items and the error message is so unhelpful (http 500 error with ajax) it took me hours to realize what was happening the first time. I'd suggest adding pagination to the default view as that fixes it, though slightly less elegantly than the suggested workaround. But at least it doesn't require installation of another module or a dependency on that module from this one.
This works great!
Honestly, I've used this so much I'm gonna mark it as tested. Would love to see a tagged release with d10 set as supported
I've added an accessCheck(TRUE)
to both /src/Form/FeeForm.php
and /src/FeeListBuilder.php
.
There are also queries executed in the /commerce_fee.post_update.php
. Do we need to add this there as well?
RedEight β created an issue.
I tried installing installing this on a d10 site but ran into some issues. I think it might be because the composer.json file specifies "drupal/core": ">=9.3"
when it should probably have a similar wildcard to the info.yml file. Thoughts on how to get this installed on a d10 site?
Not sure if it is related, but checking the "Expand all menu links" option in the block configuration doesn't even stick when saving. I checked the configuration for the block itself and that value is set to "FALSE" even when I just saved it turned on.
I've been using this to build out a site on D10 and it works great. Would love to see this released for d10 officially.
Any word on tagging a release as 10 supported so we can install with composer?
Any chance we could get a release with this so it can be installed via composer on d10 sites?
Patch seems correct.