accessChecks(TRUE) now required due to removal of default behavior in Drupal 10

Created on 19 May 2023, about 1 year ago

Updated 2 November 2023, 8 months ago

Problem/Motivation

https://www.drupal.org/node/3201242 → details the deprecation of queries that assumed accessCheck(TRUE). This has been the case since 9.2 and in Drupal 10 it will now throw an error. We need to add explicit ->accessCheck(TRUE) to all queries that don't already specify an accessCheck.

Steps to reproduce

Install Commerce Fee on Drupal 10 and try to access /admin/commerce/fees.

Proposed resolution

Wherever a query is executed, specify ->accessCheck(TRUE) if there isn't one specifying FALSE already.

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

🐛 Bug report

Status

Needs review

Version

1.0

Component

Code

Created by

🇺🇸United States RedEight

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @RedEight
Comment about 1 year ago →
🇺🇸United States RedEight
I've added an accessCheck(TRUE) to both /src/Form/FeeForm.php and /src/FeeListBuilder.php.

There are also queries executed in the /commerce_fee.post_update.php. Do we need to add this there as well?
Status changed to Needs review 8 months ago9:33am 2 November 2023
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
last update 8 months ago
19 pass
Comment 8 months ago →
🇮🇳India dineshkumarbollu
Hi

According to this https://www.drupal.org/node/3201242 → whenever we call entityquery from Drupal 9.2 onwards need to add accescheck.created patch please review.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024