- Issue created by @ressa
- 🇫🇷France dydave
Thanks a lot @ressa for getting this going! 🙏
Ideally, I would like to get the following issues merged before creating the next release:
-
#3487246-16: Warn site owners about the removal of Admin Toolbar Links Access Filter →
:
No impact at all on the module, so very safe. Additional reviews of the wording, text/message would be appreciated. -
🐛
Some mandatory parameters are missing ("source") to generate a URL for route
Active
:
Pretty much ready to go: It has received feedback from several users, but more testing and reviews would certainly be welcome. -
📌
GitlabCI: Fix ESLINT validation errors
Active
:
This is a big one.... The impact is high and should maybe be split into two tickets, one foradmin_toolbar.js
and one foradmin_toolbar_search.js
.
It has already received quite a lot of testing though from @andresalvarez and myself. But more testing is definitely required.
Overall, the most sensitive issue is the one related with the work on ESLINT and the impacted major JS files.
The problem is that currently the module doesn't have FunctionalJavascript Tests foradmin_toolbar
...
It does seem to have FunctionalJavascript Tests foradmin_toolbar_search
though, see:
https://git.drupalcode.org/project/admin_toolbar/-/tree/3.x/admin_toolba...
But I'm not sure how reliable they could be and the types of issues that may arise with certain browser compatibility issues, etc...On the side, I've started working in a local branch on converting
admin_toolbar.js
to full Vanilla JS, so I was hoping I could combine this work with the ESLINT fixes in a ticket, which would only really leave testing theadmin_toolbar_search.js
(JQuery).But if we find it too risky for this release and hard to test properly, we could also consider moving the ESLINT fixes to the next release and tag a new stable straight away 👌
Otherwise if we receive positive feedback and reviews on these issues and the corresponding merge requests, we should definitely be able to tag the new 3.6.0 stable release.
Thanks in advance! 🙂 -
#3487246-16: Warn site owners about the removal of Admin Toolbar Links Access Filter →
:
- 🇩🇰Denmark ressa Copenhagen
You're welcome @dydave, and great to see more issues added, thanks!
And nice that you explained your hopes and plans for the module, and importance of the different issues, it will surely help the community to know where to put their efforts.
I have added an issue under "Nice to have", about updating the shortcut to a more universally supported solution, perhaps it's possible to include that as well? 🤞
- 🇫🇷France dydave
Thanks @ressa!
No worries, we'll take a quick look at that issue.Any chance you could take a look at the following one?
✨ Add local tasks (tabs) for Admin Toolbar Settings forms ActiveIt should be an easy one, since there isn't any impact on module's code or logic.
Just added Tabs on modules config forms.
But we would still appreciate some feedback on the feature in general and the labels of the tabs, if possible 🙂Added at the top of the list of the IS, since it is accessible to any contributor (not necessarily tech-savvy), with any level or experience.
Thanks in advance!