[Meta] Roadplan for Admin Toolbar 3.6

Thanks a lot @ressa for getting this going! 🙏

Ideally, I would like to get the following issues merged before creating the next release:

• #3487246-16: Warn site owners about the removal of Admin Toolbar Links Access Filter → :
  No impact at all on the module, so very safe. Additional reviews of the wording, text/message would be appreciated.
• 🐛 Some mandatory parameters are missing ("source") to generate a URL for route Active :
  Pretty much ready to go: It has received feedback from several users, but more testing and reviews would certainly be welcome.
• 📌 GitlabCI: Fix ESLINT validation errors Active :
  This is a big one.... The impact is high and should maybe be split into two tickets, one for admin_toolbar.js and one for admin_toolbar_search.js.
  It has already received quite a lot of testing though from @andresalvarez and myself. But more testing is definitely required.

 
Overall, the most sensitive issue is the one related with the work on ESLINT and the impacted major JS files.
The problem is that currently the module doesn't have FunctionalJavascript Tests for admin_toolbar...
It does seem to have FunctionalJavascript Tests for admin_toolbar_search though, see:
https://git.drupalcode.org/project/admin_toolbar/-/tree/3.x/admin_toolba...
But I'm not sure how reliable they could be and the types of issues that may arise with certain browser compatibility issues, etc...

On the side, I've started working in a local branch on converting admin_toolbar.js to full Vanilla JS, so I was hoping I could combine this work with the ESLINT fixes in a ticket, which would only really leave testing the admin_toolbar_search.js (JQuery).

But if we find it too risky for this release and hard to test properly, we could also consider moving the ESLINT fixes to the next release and tag a new stable straight away 👌
 

Otherwise if we receive positive feedback and reviews on these issues and the corresponding merge requests, we should definitely be able to tag the new 3.6.0 stable release.
Thanks in advance! 🙂

You're welcome @dydave, and great to see more issues added, thanks!

And nice that you explained your hopes and plans for the module, and importance of the different issues, it will surely help the community to know where to put their efforts.

I have added an issue under "Nice to have", about updating the shortcut to a more universally supported solution, perhaps it's possible to include that as well? 🤞

Thanks @ressa!
No worries, we'll take a quick look at that issue.

Any chance you could take a look at the following one?
✨ Add local tasks (tabs) for Admin Toolbar Settings forms Active

It should be an easy one, since there isn't any impact on module's code or logic.
Just added Tabs on modules config forms.
But we would still appreciate some feedback on the feature in general and the labels of the tabs, if possible 🙂

Added at the top of the list of the IS, since it is accessible to any contributor (not necessarily tech-savvy), with any level or experience.

Thanks in advance!

Just adding a "Remaining task" item about the search shortcut, and moving it into the "Planned" list :)
(Renamed from "Important" ...)

Maybe we can squeeze this issue in as well?

 
Shall we plan for a release around the 21st of May 2025 (05/21/2025)?
(3 months after the last stable release)

We could certainly descope certain issues (postpone), in particular the one with ESLINT, which would probably need more help testing/reviewing and feedback.

Otherwise, I wouldn't see any other issues listed in the IS that could prevent from creating a release around the end of the month 👌

We could wait longer, if requested or necessary and would be glad to consider more issues to be added to the list 🙂

Any feedback, comments, or help on any of the pending issues would be greatly appreciated.
Thanks in advance! 🙏

I think aiming for 21 May 2025 as a release date for version 3.6 sounds like a great plan, looking forward to it 🙂
I have moved the LINT issue down to "Nice to have issues", as you suggested, to clarify that it's not a blocker.

Adding a tiny improvement for search result list colour, maybe it can also be included?

Adding one more small improvement, if possible? :)

Adding another one to the list 😅

Nice, removing CHANGELOG.txt was low-hanging fruit for easy picking, so great to get included!

I moved 🐛 Warn site owners about the removal of Admin Toolbar Links Access Filter Active under a new "Possibly postponed" header, since 21 may is getting closer ... isn't that the right thing to do? Also, it allows the users to have a few days, trying the latest dev-version, and report back if they find anything. If the Link Access issue does get done in time, it can always get included.

That's it @ressa! 🥳

The new 3.6.0 release → is out! 🤩

This is probably when we really start receiving feedback on how we've managed breaking the module on sites 😅😆

Otherwise, I tried writing a bit of documentation on the release, with a short summary on the maintenance tasks and bug fixes, but a big highlight on the added features 👍

I thought it would be good to let everybody know about the new keyboard shortcuts and the pretty cool slide in/out sticky behavior.

I've also added a paragraph on some of the BC breaking code changes... Next time, in such cases, I will probably issue a change record, it will probably be easier 😅

25 issues with 19 contributors over 3 months!! It's enormous !! 😆🥳
We've managed taking the number of active tickets from more than 80 down under 30 \o/ a much more manageable base of active tickets, more realistic and easier to maintain.
We've greatly tightened the code base with improved Tests and stricter validation jobs allowing a much more efficient validation of changes submitted by contributors.

Really happy we could work together on this @ressa and this release would certainly not have been possible without all your great help, guidance and cooperation 🙏
Many of the features in this new release are based on your ideas, functional designs and suggestions.

Thanks again so much for your help working with other contributors and I, through rounds of changes in merge requests, your reviews, advice, discussions, issue summary updates, etc...
It definitely greatly contributed to making this module much better! 🙂
 

Very happy this release is now behind us, so we are now able to start looking at the next sprint/release, with already a bunch of tickets lined up in the issue queue, in particular: accessibility improvements, ESLINT fixes (let's get this in ASAP in DEV👌), compatibility with Gin, more configuration settings, etc...
I've also started working on 🐛 zindex issue between admin toolbar and ckeditor 5 Active 😅 and made good progress already 🤞
We could already start cloning this ticket to: [Meta] Roadplan for Admin Toolbar 3.7😆
and start sticking tickets on there.
 

Lastly, I'd would like to thank once again very much all other contributors with whom I had the great chance and pleasure to interact and work on the issues included in this release. I definitely learnt a lot and met great people with whom to share the same passion for Drupal and Open Source development 🤝

Marking issue as Fixed for now.

Feel free to let us know if you have any questions or concerns on any aspects of this ticket, the latest 3.6.0 release → or the project in general, we would certainly be glad to help.
Thanks in advance!

Fantastic @dydave, congratulations and thank you for all your efforts! 🚀 Always a fast and positive response, and openness to suggestions, which is a big motivator for engaging in Open Source projects.

I just updated a Drupal installation with Composer, and ran the database updates, and it all went through flawlessly. So that worked really well for me, so that's one confirmation, which is a start. But yes, when you make changes, stuff happens 🙂

I got to head out now, but will check all the rest of your comment, including the comprehensive release notes under https://www.drupal.org/project/admin_toolbar/releases/3.6.0 → later, at a glance it looks amazing!

I had time to read the documentation in the the release notes, and it's absolutely spot on @dydave! It ought to be singled out as the perfect example of a Release Note, since it includes all the most important bits to cover, like run database updates, new features, overall changes, who was involved,, the issues, etc.

And yes, it has been a pretty epic overhaul, during the last few months, with a lot of activity. It's an impressive amount of bug squashing, and features added 🙂 But only made possible by swift replies and updates from you, preventing any issue from stalling. It's so awesome that you prioritized spending time on Admin Toolbar, which I am very grateful for, to the great benefit of the rest of the Drupal community. It has been an honour to be able to help you and the rest of the community out with what I can, and assist you getting the code updated, while removing old stuff. Great with a spring cleaning!

And yes, let's look forward to the next release. It's good to see that Meta 3.7 has been created, and already there are issues in that Meta issue, and that project page and README updates are included 🚀