Database query metadata missing for Views queries altered for cache key generation

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Attached patch against Drupal 10.1.x

Patch #7 is not applied for Drupal 10.1.x so Inter-diff file is not added.

Checking patch core/modules/views/src/Plugin/views/cache/CachePluginBase.php...
error: while searching for:
// the query objects.
if ($build_info[$index] instanceof Select) {
$query = clone $build_info[$index];
$query->preExecute();
$build_info[$index] = [
'query' => (string) $query,

error: patch failed: core/modules/views/src/Plugin/views/cache/CachePluginBase.php:203
error: core/modules/views/src/Plugin/views/cache/CachePluginBase.php: patch does not apply
Checking patch core/modules/views/tests/modules/views_test_config/views_test_config.module...
Checking patch core/modules/views/tests/src/Kernel/Plugin/CacheTest.php...

#11 seems to be making out of scope changes

next reroll should be from #7

Patch comment #13 && Also attached is the diff file.

Try to fixed #14 Issue.

Fixed coding standard and rerolled patch for 10.1.x

#16 appears to have a lot of out of scope changes. Patch almost tripled in size.

Hiding all patches back to #7

Please include an interdiff with all patches also

Leaving needs reroll tag.

Thanks!

Patch size increased because in the #16 phpcserrors also fixed. Attaching interdiff file for the same.

That's not correct unfortunately, adding phpcs fixes for something the patch isn't changing.

Leaving the Needs reroll tag and hiding patches up until #7

Please review.

That appears to be correct.

Thanks!

Triaging the RTBC quee.

I read the issue summary and then skimmed through the comments. I see that a question was asked in #5 that has not been answered. The comment in #3 confirms the logic of the fix but there is no review of the test.

Setting back to needs works for the question raised in #5 and to review the tests. Does the test fail when the fix is removed?

@manishsaharan, Drupal core has rather strict guidelines for what is included in a patch/MR. For information on how we scope issues there is Issue scope guidelines for Drupal core issues → . Coding standard fixes are done in separate issues, see 📌 [Meta] Fix coding standards in core Active .