- last update
over 1 year ago Custom Commands Failed - π¦πΊAustralia mstrelan
Patch for 11.x since gitlab won't let me create a new branch.
- Status changed to Needs work
over 1 year ago 2:44pm 31 May 2023 - Status changed to Needs review
over 1 year ago 10:42pm 31 May 2023 - last update
over 1 year ago 29,402 pass - Status changed to RTBC
over 1 year ago 6:30pm 1 June 2023 - πΊπΈUnited States smustgrave
Wasn't sure how to test.
So I applied locally on 11.x and haven't encountered any issues with the change applied all day.
Let me know if there's a better way. Going to mark for now.
- last update
over 1 year ago 29,411 pass - last update
over 1 year ago 29,415 pass 57:38 54:11 Running- last update
over 1 year ago 29,436 pass - last update
over 1 year ago 29,437 pass - last update
over 1 year ago 29,443 pass - last update
over 1 year ago 29,450 pass - last update
over 1 year ago 29,486 pass - last update
over 1 year ago 29,499 pass - last update
over 1 year ago 29,505 pass - Status changed to Needs review
over 1 year ago 7:20am 22 June 2023 - π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Just a couple of questions about where we might need to add a length check of optional chaining
-
+++ b/core/misc/entity-form.js @@ -52,14 +52,14 @@ - translate = $checkbox.is(':checked') + translate = $checkbox[0].checked
Do we need a length check here?
-
+++ b/core/modules/media/js/type_form.js @@ -26,7 +26,7 @@ + if (!$(context).find('#edit-options-status')[0].checked) {
do we need a length check here too? or ?.checked
-
+++ b/core/modules/menu_ui/menu_ui.js @@ -18,9 +18,7 @@ + if ($context.find('.js-form-item-menu-enabled input')[0].checked) { +++ b/core/modules/node/content_types.js @@ -32,7 +32,7 @@ + if (!$(context).find('#edit-options-status')[0].checked) { @@ -64,7 +64,7 @@ + if (!$editContext.find('#edit-display-submitted')[0].checked) { +++ b/core/modules/node/node.js @@ -40,7 +40,7 @@ + if ($optionsContext.find('input')[0].checked) {
here too
-
- Status changed to Needs work
over 1 year ago 2:36pm 22 June 2023 - Status changed to Needs review
over 1 year ago 3:57am 23 June 2023 - last update
over 1 year ago 29,551 pass - π¦πΊAustralia mstrelan
#24.1 it's already inside a length check:
if ($checkbox.length) { translate = $checkbox[0].checked ? Drupal.t('Needs to be updated') : Drupal.t('Does not need to be updated'); } else { $checkbox = $translationContext.find( '.js-form-item-translation-retranslate input', ); translate = $checkbox[0].checked ? Drupal.t('Flag other translations as outdated') : Drupal.t('Do not flag other translations as outdated'); }
#24.2 and #24.3 how about we use the
:checked
selector and check the length? - Status changed to RTBC
over 1 year ago 9:14pm 24 June 2023 - last update
over 1 year ago 29,553 pass -
larowlan β
committed cd9fed87 on 11.x
Issue #3238849 by mstrelan, hooroomoo, smustgrave, bnjmnm, larowlan:...
-
larowlan β
committed cd9fed87 on 11.x
- Status changed to Fixed
over 1 year ago 7:02am 26 June 2023 Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
over 1 year ago 4:13am 24 August 2023 - π¨π¦Canada joseph.olstad
Great work above, however it's only in 11.x, this fix should go into 10.0.x and 10.1.x.
I tested the misc.js file from 11.x and put it into my D10.0.10, it fixes a javascript error I have.
It would be nice to get this fix into Drupal 10.0.x and Drupal 10.1.x
see related issues.
- π¨πSwitzerland berdir Switzerland
I'm getting JS errors in multiple Paragraph Browser tests on line 62 around the checkbox stuff that was discussed above. Created π Javascript errors in entity-form.js when retranslate checkbox does not exist Active .