Layout builder filter leaves blank space

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

+++ b/core/modules/layout_builder/js/layout-builder.js
@@ -43,9 +43,17 @@
+          $linkJquery.parent().toggle(textMatch);

nitpick/personal preference, I'd name this $link - the $ indicates its a jQuery object

I think we need a 9.5 version of this patch with the es6 and compiled version

Can work on a 9.5 patch once this lands.

Applied patch #91 on Drupal 10.1.x-dev.
The patch applied cleanly.
The issue got fixed after applying the patch.
Refer to the previous before and after screenshots.

Also, tried to apply the patch on the 9.5 version but patch failed to apply with below error:

Checking patch core/modules/layout_builder/js/layout-builder.js...
error: while searching for:
         *   The link to add the block.
         */
        const toggleBlockEntry = (index, link) => {
          const textMatch =
            link.textContent.toLowerCase().indexOf(query) !== -1;
          $(link).toggle(textMatch);
        };

        // Filter if the length of the query is at least 2 characters.

error: patch failed: core/modules/layout_builder/js/layout-builder.js:43
error: core/modules/layout_builder/js/layout-builder.js: patch does not apply
Checking patch core/modules/layout_builder/tests/src/FunctionalJavascript/BlockFilterTest.php

Verified and tested patch #91 on 10.1.x-dev. Patch applied cleanly.

Test Results:
1. Blank Space issue is no longer reproducible on 10.1.x-dev.
2. When changing a matching string to a shorter matching string then filter work and results match. For ex. When searched for "ch", then searched "cha" and then again searched "ch", all matching results are displayed.

Refer attached video for before and after patch.

@smustgrave This patch resolves the https://www.drupal.org/project/drupal/issues/3103506 🐛 Layout Builder Add Block filter doesn't update after changing a matching string to a shorter matching string Closed: duplicate issue.

Closed 🐛 Layout Builder Add Block filter doesn't update after changing a matching string to a shorter matching string Closed: duplicate as a duplicate and moved over credit.

smustgrave → credited tedbow → .

smustgrave → credited oknate → .

Here is a re-roll for the 9.5.3 version

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

+++ b/core/modules/layout_builder/js/layout-builder.js
@@ -43,9 +43,15 @@
+          // Checks if a category is currently hidden. Toggles the category on if so.

extreme nit pick ™️ - greater than 80 chars here

other than that I think this is ready

addressed 103

Added screenshots to issue summary

Committed a5291f0 and pushed to 10.1.x. Also cherry-picked to 10.0.x. Thanks!

We still need a patch for 9.5.x since this is eligible for backport.

lauriii → closed merge request !1310

Adding patch for 9.5.x as requested in #108

#110 failed the build.

Solving CCF from#110

Solving CCF from#112

Re-rolled patch for 9.5.x, attached interdiff for same.

Committed 06eac4f and pushed to 9.5.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.