- 🇺🇸United States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.
Hiding #31 as that seems to be unrelevant to this issue
Can confirm the issue still in D10
This may also be solved with 🐛 Layout builder filter leaves blank space Fixed could someone test that patch out?
- Status changed to Needs work
almost 2 years ago 6:08pm 6 February 2023 - 🇮🇳India sonam.chaturvedi Pune
Tested patch #35 on 10.1.x-dev. Patch does not apply cleanly.
Checking patch core/modules/layout_builder/js/layout-builder.js... Checking patch core/modules/layout_builder/tests/src/FunctionalJavascript/BlockFilterTest.php... error: while searching for: $this->assertCount(1, $visible_categories); $this->assertAnnounceContains('1 block is available in the modified list.'); // Test Drupal.announce() message when no matches are present. $filter->setValue('Pan-Galactic Gargle Blaster'); $visible_rows = $this->filterVisibleElements($blocks); $this->assertCount(0, $visible_rows); $visible_categories = $this->filterVisibleElements($categories); $this->assertCount(0, $visible_categories); $announce_element = $page->find('css', '#drupal-live-announce'); $page->waitFor(2, function () use ($announce_element) { return str_starts_with($announce_element->getText(), '0 blocks are available'); }); // Test Drupal.announce() message when all blocks are listed. $filter->setValue(''); $this->assertAnnounceContains('All available blocks are listed.'); error: patch failed: core/modules/layout_builder/tests/src/FunctionalJavascript/BlockFilterTest.php:108 error: core/modules/layout_builder/tests/src/FunctionalJavascript/BlockFilterTest.php: patch does not apply
Needs work
- 🇺🇸United States smustgrave
Can you test 🐛 Layout builder filter leaves blank space Fixed to see if it solves your problem? When I tested over there it does. So this could maybe be marked a duplicate.
- 🇮🇳India sonam.chaturvedi Pune
Tested 🐛 Layout builder filter leaves blank space Fixed and it resolves the filtering issue on 10.1.x-dev.
I have added my results in there. - Status changed to Closed: duplicate
almost 2 years ago 6:40pm 6 February 2023 - 🇺🇸United States smustgrave
Thanks closing as duplicate and moving credit.