- 🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
Try TO Fix The Failed #62 Patch.
- Assigned to adeshsharma
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 5:39am 15 March 2023 - Status changed to Needs work
over 1 year ago 4:01pm 15 March 2023 - 🇺🇸United States smustgrave
Cleaning up credits for bad rerolls/empty commits as it's expected to check your patches before uploading.
Patch #62 seemed to address the points and at the time the only failure was a random one. Still need to double check that the points are addressed.
Hiding patches #64 (no interdiff and patch before applied fine) and #67 (reverted back to patch 52 so would miss any potential fixes in 62).
=====
Just FYI to help get the message out there.
Starting March 2023, simple rerolls, rebases, or merges will no longer receive issue credit. Only rerolls that address a merge conflict will be credited, and the merge conflict that was resolved must be documented in the text of an issue comment.
Example
error: patch failed: core/modules/system/tests/modules/twig_theme_test/twig_theme_test.module:77
error: core/modules/system/tests/modules/twig_theme_test/twig_theme_test.module: patch does not applyTo receive credit for contributing to this issue, assist with other outstanding tasks or unaddressed feedback.
See the issue credit guidelines → for more information. - Status changed to Needs review
over 1 year ago 4:52am 17 March 2023 - Status changed to Needs work
over 1 year ago 2:17pm 17 March 2023 - 🇺🇸United States smustgrave
CC Failure.
BUT #67 skipped all the points there were attempted in #62.
So this appears to be carrying forward the wrong patch.
Think #62 should be the starting point.
- First commit to issue fork.
- @rpayanm opened merge request.
- Status changed to Needs review
over 1 year ago 4:22am 20 March 2023 - 🇮🇳India adeshsharma Bhopal
Checking to see if "…" character got fixed in my last patch. Includes suggestions from #62.
- Status changed to Needs work
over 1 year ago 1:58pm 20 March 2023 - 🇺🇸United States smustgrave
Not sure #62 was the starting point. The interdiffs say it was 67. also the file sizes slightly went up what was the additional file needed that wasn't in #62?
- Status changed to Needs review
over 1 year ago 4:34am 22 March 2023 - Status changed to Needs work
over 1 year ago 7:02am 22 March 2023 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- last update
over 1 year ago Patch Failed to Apply - 🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
Fix The Failed Patch #76 For Drupal 11.x.
also, Add The Interdiff FOr 76-78. - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - Status changed to Needs review
over 1 year ago 1:31pm 20 June 2023 - last update
over 1 year ago Patch Failed to Apply - 🇧🇷Brazil lucienchalom
- last update
over 1 year ago 29,499 pass - Status changed to RTBC
over 1 year ago 3:06pm 20 June 2023 - 🇺🇸United States smustgrave
Cleaning up patches.
I think what you have in #79 is good. The words from the issue summary have been removed and aren't throwing errors.
Code has to be merged into 11.x first and backported later.
- last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - Status changed to Needs work
over 1 year ago 1:36pm 22 July 2023 - Status changed to Needs review
over 1 year ago 10:48am 23 July 2023 - last update
over 1 year ago 29,878 pass - 🇳🇿New Zealand quietone
I applied the latest patch locally and rerolled. Then I looked back at the reviews, particularly those by xjm who is very good at spelling and grammar. I found that #36.1 was not done. That got me looking closer at the rerolls. I found that the reroll in #48 was incorrect and removed at the least the fix for #36.1. longwave spotted the problem, #60, but unfortunately, the next patch also didn't make the requested change.
There was no interdiff supplied in #48 so that didn't help other to spot it. But it is a reminder for all of us to make an interdiff and review it before working on a patch.
After that I went back through each review to make sure all the changes were made. I hope I didn't miss any. Here are the changes I made.
#15
1) Fixed, longblob and mysqldump stay in the dictionary. Same as #22
2) Fixed. Same as #36,1
3) Similar to #36.2#36
1) Done,Implement lazy-loading
.
2) Reworked to avoid a word in the dictionary and an ignore line.
3- 4) were correct in the latest patch.After, that I rebuillt the dictionary and updated the list of removed words in the issue summary.
Finally, I am removing credit for the creation of the MR, according to How is credit granted for Drupal core issues → .
- Status changed to RTBC
over 1 year ago 3:21pm 23 July 2023 -
longwave →
committed 235b1393 on 10.1.x
Issue #3219475 by quietone, adeshsharma, ravi.shankar, lucienchalom,...
-
longwave →
committed 235b1393 on 10.1.x
-
longwave →
committed 1bb050ca on 11.x
Issue #3219475 by quietone, adeshsharma, ravi.shankar, lucienchalom,...
-
longwave →
committed 1bb050ca on 11.x
- Status changed to Fixed
over 1 year ago 4:23pm 23 July 2023 Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
about 1 year ago 11:27pm 11 September 2023 - 🇬🇧United Kingdom alexpott 🇪🇺🌍
Unfortunately it looks like this patch fixed some spellings without updating the dictionary, for example:
litererally
- see 🐛 Remove incorrect spellings form the dictionary that are no longer in the codebase Needs review