- Issue created by @alexpott
- Status changed to Needs review
about 1 year ago 11:25pm 11 September 2023 - last update
about 1 year ago 29,473 pass - last update
about 1 year ago Patch Failed to Apply - π¬π§United Kingdom alexpott πͺπΊπ
+++ b/core/misc/cspell/dictionary.txt @@ -620,7 +619,6 @@ linksby -litererally
... could not have made that up! π
Thanks @cilefen!
- last update
about 1 year ago 30,148 pass - π¬π§United Kingdom alexpott πͺπΊπ
Here's the patch for 11.x - where we fixed this in π Spellcheck core after removal of "Please" Fixed but then added another unnecessary word in β¨ Add optional validation constraint support to ConfigFormBase Fixed
So this issue now has patches for 10.1.x and 11.x that make the dictionary the same as what
yarn run spellcheck:make-drupal-dict
would generate on each branch.We need to open an issue to discuss how we can test if dictionary.txt is correct.
- Status changed to RTBC
about 1 year ago 8:22am 12 September 2023 - π¬π§United Kingdom longwave UK
Given we have parallel jobs in GitLab can we afford to do a full cspell run on every MR/commit?
- π¬π§United Kingdom alexpott πͺπΊπ
@longwave that would not fix this - unfortunately - as we're removing words from the custom dictionary. What we can do is have a job that runs the dictionary making command and ensure that nothing changes.
- Status changed to Fixed
about 1 year ago 9:40am 12 September 2023 - π¬π§United Kingdom catch
Currently even the partial cspell run is the slowest, or sometimes nearly slowest depending on queueing, of the linting steps, which blocks all the test groups from running, so it would probably add however much extra time it takes to the total length of runs. We could definitely open an issue to see how much difference it makes. I also opened π Run jobs on GitLab CI branch tests Fixed .
Committed/pushed to 11.x and 10.1.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.