Switch to border-box as default box-model (box-sizing)

Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 2 years ago
29,367 pass
Comment about 2 years ago →
🇮🇳India gauravvvv Delhi, India
I have attached the patch, please review
Status changed to RTBC about 2 years ago10:18pm 1 May 2023
Comment about 2 years ago →
🇺🇸United States smustgrave
Changes seems simple enough.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 2 years ago
29,374 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 2 years ago
29,378 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 2 years ago
29,379 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 2 years ago
29,380 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 2 years ago
29,383 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 2 years ago
29,388 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 2 years ago
29,388 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 2 years ago
29,388 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
29,387 pass, 2 fail
Comment almost 2 years ago →
System Message
The last submitted patch, 10: 3192130-10.patch, failed testing. View results →
Status changed to Needs review over 1 year ago8:25am 12 October 2023
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
30,341 pass
Comment over 1 year ago →
🇮🇳India swatidhurandhar
I have created a new patch since #11 was failing through some test cases.
Status changed to RTBC over 1 year ago1:15pm 12 October 2023
Comment over 1 year ago →
🇮🇳India viren18febs
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
30,394 pass
Comment over 1 year ago →
🇺🇸United States smustgrave
11.x is the current development branch and #10 still applies
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
30,341 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
30,327 pass, 2 fail
Comment over 1 year ago →
System Message
The last submitted patch, 13: 3192130-13.patch, failed testing. View results →
Comment over 1 year ago →
🇮🇳India gauravvvv Delhi, India
Random failure, restoring status
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
30,341 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
30,341 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
30,341 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
30,341 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
30,341 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
30,341 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
30,341 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
30,341 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
30,341 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
30,341 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
30,341 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
30,341 pass
Status changed to Needs work over 1 year ago11:44pm 10 November 2023
Comment over 1 year ago →
needs-review-queue-bot
The Needs Review Queue Bot → tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)
First commit to issue fork.
@ameymudras opened merge request.
Status changed to RTBC over 1 year ago3:41am 14 November 2023
Comment over 1 year ago →
🇫🇷France nod_ Lille
restoring status, credited for target version update
Comment over 1 year ago →
🇫🇷France nod_ Lille
I do not understand what this changes practically.

The IS mentions that it causes unnecessary calculations but there is no simplifications in the code at all. I'm tempted to close this issue as "works as designed" if we don't have any other change in this MR.
Status changed to Needs work over 1 year ago3:46am 14 November 2023
Comment over 1 year ago →
🇫🇷France nod_ Lille
Status changed to Closed: works as designed over 1 year ago6:24pm 14 December 2023
Comment over 1 year ago →
🇺🇸United States smustgrave
Per #22 since there hasn't been any follow up.

Switch to border-box as default box-model (box-sizing)

Problem/Motivation

Proposed resolution

Comments & Activities