- ๐ณ๐ฑNetherlands sander.bras
Because of a recent accessibility audit, we had to change the way the text "this link/mail is external" is set.
aria-labelledby on the svg tag is not supported by all screenreaders.
We went for the most reliable way, of just including a 'visually-hidden' next to the icon, that is supported by all screenreaders.
The SVG icon still has it's own title, so visual users can hover over the icon, and get a popup with the text.
But we've also added aria-hidden=true to the SVG itself, so that screenreaders won't pronounce the text twice.
We do see further improvements to accessibility for the placement of the text (it should always be after the link, despite of the position settings), but that is out of scope for this ticket, and we'll make a new one for that. - ๐ฎ๐นItaly kopeboy Mainland
- Status changed to RTBC
about 2 months ago 4:16pm 29 April 2024 - ๐ฎ๐นItaly kopeboy Mainland
Actually there was an error at extlink.install: the update was re-declared but I think it should replace the previous extlink_update_8103
I'm noob but after this my updb worked.
I consider this reviewed as I only re-applied @sander.bras work from #23 and tested that it worked.
- Status changed to Needs work
about 1 month ago 9:16am 22 May 2024 - ๐ฉ๐ชGermany Anybody Porta Westfalica
@kopeboy thank you, but please provide it as MR.
- First commit to issue fork.
- ๐ฎ๐ณIndia immaculatexavier
immaculatexavier โ changed the visibility of the branch 3186584- to hidden.
- ๐บ๐ธUnited States smustgrave
This will need an issue summary update as not super clear what's being proposed. Seems to be adding new settings.