Cleanup SVG icon markup

Because of a recent accessibility audit, we had to change the way the text "this link/mail is external" is set.
aria-labelledby on the svg tag is not supported by all screenreaders.
We went for the most reliable way, of just including a 'visually-hidden' next to the icon, that is supported by all screenreaders.
The SVG icon still has it's own title, so visual users can hover over the icon, and get a popup with the text.
But we've also added aria-hidden=true to the SVG itself, so that screenreaders won't pronounce the text twice.
We do see further improvements to accessibility for the placement of the text (it should always be after the link, despite of the position settings), but that is out of scope for this ticket, and we'll make a new one for that.

Very good, thank you!

The patch was not applying to latest dev version, so this is the new one.

→

Actually there was an error at extlink.install: the update was re-declared but I think it should replace the previous extlink_update_8103

I'm noob but after this my updb worked.

I consider this reviewed as I only re-applied @sander.bras work from #23 and tested that it worked.

Here the new patch →

@kopeboy thank you, but please provide it as MR.

immaculatexavier → changed the visibility of the branch 3186584- to hidden.

This will need an issue summary update as not super clear what's being proposed. Seems to be adding new settings.

smustgrave → closed merge request !1

smustgrave → closed merge request !2

Can the IS be updated, else going to close this one out.

Working on it.

Some further comments:

1. Although I had to set @kopeboy → as the commit author because actually he was who uploaded the patch file I applied, but I think everyone agrees that all credits should go to @bskibinski → who actually took the development time to improve the module. Dear module maintainers, please make sure that he will receive his well-earned credits when the ticket gets Fixed finally.
2. The MR targets the then-default 8.x-1.x branch intentionally because that was closer to these old patches uploaded here (thus lower chance of conflicts). Once a working solution gets accepted, then we will need to port that to the current default 2.x branch too.
3. Issue summary has been update also based on the code changes suggested, relevant issue tag removed.
4. Also hiding all the patches as we use merge requests on GitLab from now on.

Current solution should land in 2.0.x first as there have been a ton of changes there. Will be very different

And the user bskibinski is already checked at the bottom

I created a PR for 2.0.x, but it still needs some work on the SVGs, I think.

Here is the PR as a patch.

smustgrave → closed merge request !31

smustgrave → closed merge request !40

Seems more like a feature request looking at the patch. Am tagging for issue summary as the proposed solution doesn't match.

So I removed the adobe stuff per the title.

Not sure why the additional stuff was needed so will leave the ticket open but think it can be closed.

Automatically closed - issue fixed for 2 weeks with no activity.