I was thinking of having the option of specifying it through the UI, so there is no need of adding mode code, but I stumbled upon the moment where more than one role can have a redirect, and I'm not sure how to solve that, would be nice to use the redirect of the more permissive role, but that might differ from site to site, so now it makes sense again to use that event... Thanks for pointing me out in that direction.
Anyway, I upload the patch that I created, where is just tries to use one of the redirects from the roles.
edurenye → created an issue.
Rebased against 2.x again.
Here is the PR as a patch.
I created a PR for 2.0.x, but it still needs some work on the SVGs, I think.
edurenye → made their first commit to this issue’s fork.
Time to start with Drupal 11 support, I'll close this issue.
Time to start with Drupal 11 support, I'll close this issue.
Looks good to me. Thank you @kevineinarsson !
I created a release for Drupal 9 (
https://www.drupal.org/project/jwt_block/releases/1.0.0-alpha0 →
) in case there are people still using it in Drupal 9.
Now I'll create a new release alpha1 for Drupal 10 and 11.
Time to start with Drupal 11 support, I'll close this issue.
Rerolled the patch for Drupal 10.3.0.
Rebased against 2.x again.
The patch does no longuer apply to Drupal 10.2.2.
And `Locale::config()->updateDefaultConfigLangcodes();` is not called in `locale_system_set_config_langcodes()` anymore.
Not sure if the issue will still happen or if this should be fixed now.
Fixed a PHP error.
Rebases against 2.x.
The race condition should be fixed, since #3043180 has been merged.
I guess we still need discussion regarding the other 2 points that @pstewart mentioned.
edurenye → created an issue.
Seems like sometimes it does not work, but I'm not quite sure which conditions make it to not work, so I have the default language in Swedish, but we want the base config in English and have the translations in Swedish.
And most of the time it works but then today I changed some permissions and when I exported it wanted to add the labels in Swedish to the English base exported config, really weird.
@chilice Remember when uploading a patch to provide the intediff so it is easy to see the changes to do a review.
Added a fix for typehints in BuildIndexParamsEvent.
Maybe the real solution would have been to add the module dependency to the DateTime module instead of adding it's own format, this should follow the format of the system, don't you think?
edurenye → made their first commit to this issue’s fork.
Sorry about that, it was already fixed here: https://www.drupal.org/project/real_aes/issues/3339608 📌 Fix coding standards Fixed
edurenye → created an issue.
edurenye → created an issue.
Yes, your representation is correct.
And I like the option 2 because that might encourage others to contribute with their own plugins and that would help others at the same time.
edurenye → created an issue.
Added the plugin and some tests.
Do you think I should add more integration tests with all the 4 modules working together?
edurenye → created an issue.
edurenye → created an issue.
Aparently after fixing that there is still an error:
Exception: Only file JavaScript assets can be optimized. in Drupal\Core\Asset\JsOptimizer->optimize() (line 17 of core/lib/Drupal/Core/Asset/JsOptimizer.php).
edurenye → created an issue.
edurenye → created an issue.
edurenye → made their first commit to this issue’s fork.
We discussed about this topic in the #DrupalCampVienna2015, and we agreed to implement the generic revision UI in entity API and then move it to Core.
Here is the issue I created for that: #2625122: [Meta] Implement a generic revision UI →
What you mean exactly? Like having a TranslatableRevisionControllerTrait that extends from RevisionControllerTrait for those entities that are translatable and add the methods there or just extract buildRevertRevisionTranslationLink from buildRevertRevisionLink in RevisionControllerTrait?
Those small fixes are solved in this patch.
I did the rebase and moved the links to another method.
Fixed the failing test, basically improved the reroll, added changes that were made in this time.
Rebased.
Did all changes exept the 3, that I didn't know what to put there, was like this before, and can't get a verb for that.
And 4, 5, that I don't know how to do that.
Also in RevisionControllerTrait, I'm not sure if everything it's fine there.