Installed patch and tested functionality. Works as described.
Patch applied and works like intended.
Patch applied and works like intended.
Because of a recent accessibility audit, we had to change the way the text "this link/mail is external" is set.
aria-labelledby on the svg tag is not supported by all screenreaders.
We went for the most reliable way, of just including a 'visually-hidden' next to the icon, that is supported by all screenreaders.
The SVG icon still has it's own title, so visual users can hover over the icon, and get a popup with the text.
But we've also added aria-hidden=true to the SVG itself, so that screenreaders won't pronounce the text twice.
We do see further improvements to accessibility for the placement of the text (it should always be after the link, despite of the position settings), but that is out of scope for this ticket, and we'll make a new one for that.